Last modified: 2013-06-22 13:20:38 UTC
Patch set for CirrusSearch https://git.wikimedia.org/commitdiff/mediawiki%2Fextensions%2FCirrusSearch.git/b46c2ff0ac137bfff78d7878eb0a9075a14d7037 is missing in https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/CirrusSearch,n,z Same for Foxway: https://git.wikimedia.org/commitdiff/mediawiki%2Fextensions%2FFoxway.git/b2d424cdf056ff818385c885f04734762e91763a is missing in https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Foxway,n,z It's really hard to do good/complete i18n review when Gerrit is circumvent :-(
The title made me think that gerrit is losing commits. But it seems this is not the case. Is this bug meant as complaint that * "people should not use direct push if they want good/complete i18n review", or * "do no longer allow direct push!" ? P.S.: Once the new gerrit is deployed, we get a '%submit' option that allows pushing changes to gerrit and automatically submitting them: git push origin HEAD:refs/for/master%submit . For the pusher it's similar to direct push: The change gets merged immediately. But for reviewers the changes are visible from within gerrit.
Nothing in CirrusSearch is done yet, which is why we haven't been pushing for review...
(In reply to comment #1) > The title made me think that gerrit is losing commits. But it seems > this is not the case. > > Is this bug meant as complaint that > * "people should not use direct push if they want good/complete i18n review", > or > * "do no longer allow direct push!" I thought that direct pushing was technically restricted for core and extension repos some months ago, wasn't it? > P.S.: Once the new gerrit is deployed, we get a '%submit' option that > allows pushing changes to gerrit and automatically submitting them: > > git push origin HEAD:refs/for/master%submit > > . For the pusher it's similar to direct push: The change gets merged > immediately. But for reviewers the changes are visible from within gerrit. Great! When does the new Gerrit will landing? (In reply to comment #2) > Nothing in CirrusSearch is done yet, which is why we haven't been pushing for > review... I saw the i18n file and therefore added the extension to translatewiki.net, as usual.
(In reply to comment #3) > (In reply to comment #1) > > The title made me think that gerrit is losing commits. But it seems > > this is not the case. > > > > Is this bug meant as complaint that > > * "people should not use direct push if they want good/complete i18n review", > > or > > * "do no longer allow direct push!" > > I thought that direct pushing was technically restricted for core and > extension > repos some months ago, wasn't it? > It is, and I broke my own rules for CirrusSearch.
(In reply to comment #0) > Same for Foxway: > https://git.wikimedia.org/commitdiff/mediawiki%2Fextensions%2FFoxway.git/ > b2d424cdf056ff818385c885f04734762e91763a > > is missing in > > https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Foxway,n,z Am I missing something or is that one Gerrit change #67965 ?
(In reply to comment #5) > (In reply to comment #0) > > Same for Foxway: > > https://git.wikimedia.org/commitdiff/mediawiki%2Fextensions%2FFoxway.git/ > > b2d424cdf056ff818385c885f04734762e91763a > > > > is missing in > > > > https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Foxway,n,z > > Am I missing something or is that one Gerrit change #67965 ? Oh yes. Sorry for confusion. My fault :-(
