Last modified: 2013-07-24 16:58:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51971, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49971 - View history gives fatal error after new edit to course page
View history gives fatal error after new edit to course page
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
EducationProgram (Other open bugs)
master
All All
: Immediate critical (vote)
: ---
Assigned To: Jeroen De Dauw
:
: 51168 (view as bug list)
Depends on: 50740
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-21 17:31 UTC by Sage Ross
Modified: 2013-07-24 16:58 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sage Ross 2013-06-21 17:31:03 UTC
I made a test edit to this course page:

https://en.wikipedia.org/wiki/Education_Program:Example_University/Example_Course_%282013_Q1%29

After the edit, clicking "View history" gives a fatal error.

https://en.wikipedia.org/w/index.php?title=Education_Program:Example_University/Example_Course_%282013_Q1%29&action=history


PHP fatal error in /usr/local/apache/common-local/php-1.22wmf7/includes/db/ORMTable.php line 924:
Argument 1 passed to ORMTable::newRow() must be an array, string given, called in /usr/local/apache/common-local/php-1.22wmf7/extensions/EducationProgram/includes/rows/EPRevision.php on line 50 and defined
Comment 1 Sam Reed (reedy) 2013-06-21 18:07:07 UTC
[21-Jun-2013 18:06:18] Catchable fatal error: Argument 1 passed to ORMTable::newRow() must be an array, string given, called in /usr/local/apache/common-local/php-1.22wmf7/extensions/EducationProgram/includes/rows/EPRevision.php on line 50 and defined at /usr/local/apache/common-local/php-1.22wmf7/includes/db/ORMTable.php on line 924
Server: mw1088
Method: GET
URL: http://en.wikipedia.org/w/index.php?title=Education_Program:Example_University/Example_Course_%282013_Q1%29&action=history
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf7/includes/db/ORMTable.php(924): ORMTable::newRow()
#1 /usr/local/apache/common-local/php-1.22wmf7/extensions/EducationProgram/includes/rows/EPRevision.php(50): ORMTable->newRow('a:13:{s:2:"id";...', true)
#2 /usr/local/apache/common-local/php-1.22wmf7/extensions/EducationProgram/includes/pagers/RevisionPager.php(80): EducationProgram\EPRevision->getObject()
#3 /usr/local/apache/common-local/php-1.22wmf7/includes/Pager.php(434): EducationProgram\RevisionPager->formatRow(Object(stdClass))
#4 /usr/local/apache/common-local/php-1.22wmf7/extensions/EducationProgram/includes/actions/HistoryAction.php(118): IndexPager->getBody()
#5 /usr/local/apache/common-local/php-1.22wmf7/extensions/EducationProgram/includes/actions/HistoryAction.php(38): EducationProgram\HistoryAction->displayRevisions(Object(EducationProgram\Course))
#6 /usr/local/apache/common-local/php-1.22wmf7/includes/Action.php(547): EducationProgram\HistoryAction->onView()
#7 /usr/local/apache/common-local/php-1.22wmf7/includes/Wiki.php(439): FormlessAction->show()
#8 /usr/local/apache/common-local/php-1.22wmf7/includes/Wiki.php(305): MediaWiki->performAction(Object(EducationProgram\CoursePage), Object(Title))
#9 /usr/local/apache/common-local/php-1.22wmf7/includes/Wiki.php(565): MediaWiki->performRequest()
#10 /usr/local/apache/common-local/php-1.22wmf7/includes/Wiki.php(458): MediaWiki->main()
#11 /usr/local/apache/common-local/php-1.22wmf7/index.php(55): MediaWiki->run()
#12 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#13 {main}
Comment 2 Jeroen De Dauw 2013-06-21 18:20:41 UTC
Which revision of the software is being used here?
Comment 3 Sage Ross 2013-06-21 18:36:31 UTC
I believe that as of yesterday, it is running the up-to-date version including all the recently merged commits.
Comment 4 Greg Grossmeier 2013-06-22 02:14:56 UTC
You can see from the stack trace that it is 1.22wmf7.

Can this be reproduced on test/test2.wikipedia.org or on mediawiki.org (which are running 1.22wmf8)? Actually, it appears the education program extension is only installed on test2. Can you repro it there?
Comment 5 Sage Ross 2013-06-22 09:42:36 UTC
Yes, I can reproduce it on test2.
Comment 6 Gerrit Notification Bot 2013-06-22 14:40:32 UTC
Related URL: https://gerrit.wikimedia.org/r/69978 (Gerrit Change Id719b27e9fb83be0d54a211b7006189b9444c2a0)
Comment 7 Jeroen De Dauw 2013-06-22 14:51:37 UTC
Looks like I fixed it... Really need to get rid of this old course/org/revision code :)
Comment 8 Tomer A. 2013-06-25 14:47:58 UTC
Thanks.
Comment 9 Tomer A. 2013-06-25 14:48:46 UTC
Oops, wrong bug.
Comment 10 Andre Klapper 2013-07-02 14:30:03 UTC
(In reply to comment #7)
> Looks like I fixed it...

Jeroen: So can this be closed as RESOLVED FIXED or is there more to do?
Comment 11 Sage Ross 2013-07-11 13:07:33 UTC
*** Bug 51168 has been marked as a duplicate of this bug. ***
Comment 12 Sage Ross 2013-07-11 13:09:29 UTC
I believe this was not deployed because of the related bug 50740, which was revealed when this patch deployed to test2.
Comment 13 Sage Ross 2013-07-24 16:58:33 UTC
This has been deployed (so bug 50740 is now live).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links