Last modified: 2013-07-05 19:51:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51993, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 49993 - VisualEditor: Opening "Edit" tab (and section edit links) with a middle-click / Ctrl-click / Shift-click (new tab/window) disabled somehow


Summary:	VisualEditor: Opening "Edit" tab (and section edit links) with a middle-click...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	MediaWiki integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Immediate major
Target Milestone:	VE-deploy-2013-06-27
Assigned To:	Krinkle

URL:
Whiteboard:
Keywords:

Duplicates:	50221 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-06-22 00:01 UTC by James Forrester
Modified:	2013-07-05 19:51 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-06-22 00:01:57 UTC

This doesn't work; not quite sure why/how. Should be fixed.

Comment 1 Oliver Keyes 2013-06-25 15:14:16 UTC

Some back-of-the-envelope work by users indicates that firefox (logged in) and chromium (logged out) on linux have this problem; firefox and IE on Windows (not logged in) do not.

Comment 2 T. H. Kelly (Pink&) 2013-06-26 13:11:22 UTC

I should note that I've been having this bug (well, with ctrl-click on my laptop, but think that's the same thing), and I don't have VE enabled. However, this bug's several days old, and I'm pretty sure this has only been happening to me within the past hour. Chrome on a ChromeOS netbook.

Comment 3 Bartosz Dziewoński 2013-06-26 16:41:08 UTC

*** Bug 50221 has been marked as a duplicate of this bug. ***

Comment 4 Bartosz Dziewoński 2013-06-26 16:42:33 UTC

Raising importance, this is quite annoying. It's just been reported on [[WP:VPT]] for the second time today.

Comment 5 James Forrester 2013-06-26 21:09:48 UTC

Fixed in Gerrit change #70735 which is now merged and will get pushed later today.

Comment 6 Gerrit Notification Bot 2013-06-26 23:36:26 UTC

Related URL: https://gerrit.wikimedia.org/r/70773 (Gerrit Change I5245ab19ae16b79d2c562c05b94649a58e04a4fd)

Comment 7 Oliver Keyes 2013-07-05 14:09:57 UTC

I'm not sure how the fix was implemented, but it seems to have started occurring again - this time only in namespaces in which the VE isn't active.

Comment 8 Chris McKenna 2013-07-05 14:51:58 UTC

My testing shows that ctrl+click works only in VE-enabled namespaces but middle click works everywhere in Firefox 22. 

In Konqueror 4.8.5 (which is apparently not enabled for VE) both ctrl+click and middle click both work only in VE-enabled namespaces.

Comment 9 James Forrester 2013-07-05 15:59:09 UTC

Gah, bad breakage related to making VE more lightweight - sorry about that. Gerrit change #72069 fixes this, according to my local testing - we'll try to get this out today.

Comment 10 Gerrit Notification Bot 2013-07-05 15:59:24 UTC

Change 72069 had a related patch set uploaded by Jforrester:
mw.ViewPageTarget.init: Move edit section to top init.

https://gerrit.wikimedia.org/r/72069

Comment 11 Gerrit Notification Bot 2013-07-05 18:40:14 UTC

Change 72069 merged by jenkins-bot:
mw.ViewPageTarget.init: Move edit section to top init

https://gerrit.wikimedia.org/r/72069

Comment 12 James Forrester 2013-07-05 19:51:52 UTC

Fix merged and will hopefully go out soon.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links