Last modified: 2013-07-26 07:54:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52033, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50033 - Toolbar shows on non-existent pages
Toolbar shows on non-existent pages
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GettingStarted (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-23 03:18 UTC by Matthew Flaschen
Modified: 2013-07-26 07:54 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Toolbar on deleted page (Labs) (244.74 KB, image/png)
2013-06-24 23:18 UTC, Steven Walling
Details

Description Matthew Flaschen 2013-06-23 03:18:02 UTC
The toolbar still shows if the page does not exist.

This should only happen if the page is deleted after it's first added to their openTask cookie.  S:GS has a length check (which implicitly includes checking that the page exists). Thus, this is worth fixing, but shouldn't be that common.
Comment 1 Steven Walling 2013-06-24 06:15:20 UTC
(In reply to comment #0)
> The toolbar still shows if the page does not exist.
> 
> This should only happen if the page is deleted after it's first added to
> their
> openTask cookie.  S:GS has a length check (which implicitly includes checking
> that the page exists). Thus, this is worth fixing, but shouldn't be that
> common.

I tried to replicate this on piramido.wmflabs.org by deleting a page I had just been served correctly via Special:GettingStarted with the toolbar and then returning.

I still had the openTask cookie associated with that task/article, but the toolbar did not display on the redlink view (&action=edit&redlink=1). I did, however, get the guided tour.
Comment 2 Matthew Flaschen 2013-06-24 21:49:55 UTC
(In reply to comment #1)
> I still had the openTask cookie associated with that task/article, but the
> toolbar did not display on the redlink view (&action=edit&redlink=1). I did,
> however, get the guided tour.

I think that's because it's action=edit.  If you visit directly (/wiki/Article), without action=edit, you should be able to reproduce.
Comment 3 Steven Walling 2013-06-24 23:18:17 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > I still had the openTask cookie associated with that task/article, but the
> > toolbar did not display on the redlink view (&action=edit&redlink=1). I did,
> > however, get the guided tour.
> 
> I think that's because it's action=edit.  If you visit directly
> (/wiki/Article), without action=edit, you should be able to reproduce.

Bingo. Will attach screengrab for verification.
Comment 4 Steven Walling 2013-06-24 23:18:54 UTC
Created attachment 12629 [details]
Toolbar on deleted page (Labs)
Comment 5 Gerrit Notification Bot 2013-07-20 01:06:03 UTC
Change 74822 had a related patch set uploaded by Mattflaschen:
Don't show toolbar if page does not exist.

https://gerrit.wikimedia.org/r/74822
Comment 6 Gerrit Notification Bot 2013-07-25 19:17:37 UTC
Change 74822 merged by jenkins-bot:
Don't show toolbar if page does not exist.

https://gerrit.wikimedia.org/r/74822

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links