Last modified: 2013-06-28 18:05:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52042, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50042 - Parsoid: External links are double encoded


Summary:	Parsoid: External links are double encoded

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High major
Target Milestone:	---
Assigned To:	Gabriel Wicke

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-06-23 09:27 UTC by Krinkle
Modified:	2013-06-28 18:05 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2013-06-23 09:27:13 UTC

Intended edit (ve-edit + fixup):

https://www.mediawiki.org/w/index.php?title=Wikimedia_technical_search&diff=715707&oldid=715705

-  [https://github.com/search?l=&q=wgWellFormedXml+%40wikimedia Search]
+  [https://github.com/search?l=&q=ResourceLoader+%40wikimedia Search]

Actual edit saved by Parsoid/VisualEditor:


https://www.mediawiki.org/w/index.php?title=Wikimedia_technical_search&diff=715706&oldid=715705

-  [https://github.com/search?l=&q=wgWellFormedXml+%40wikimedia Search]
+  [https://github.com/search?l=&q=ResourceLoader+%2540wikimedia Search]


Note how the % got encoded to %25.

Comment 1 Ed Sanders 2013-06-26 13:14:56 UTC

Looks like a Parsoid bug. Works fine when data-parsoid is present, but for new annotations URLs are encoded.

<a rel="mw:ExtLink" href="https://github.com/search?l=&amp;q=ResourceLoader+%40wikimedia">Search</a>

serialises to:

[https://github.com/search?l=&q=ResourceLoader+%2540wikimedia Search]

Comment 2 Gerrit Notification Bot 2013-06-28 17:41:20 UTC

Change 71082 had a related patch set uploaded by GWicke:
Bug 50042: Don't percent-encode modified external link hrefs

https://gerrit.wikimedia.org/r/71082

Comment 3 Gerrit Notification Bot 2013-06-28 17:55:39 UTC

Change 71082 merged by jenkins-bot:
Bug 50042: Don't percent-encode modified external link hrefs

https://gerrit.wikimedia.org/r/71082

Comment 4 Gabriel Wicke 2013-06-28 18:05:02 UTC

We might later want to prettify the percent encoding. Basically decode everything but some vital percent-encoded values ([%? ], probably more). But for now this is fixed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links