Last modified: 2014-02-28 23:41:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52052, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50052 - VisualEditor: Mis-nested annotations are cleaned up, leading to a dirty diff
VisualEditor: Mis-nested annotations are cleaned up, leading to a dirty diff
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-23 13:55 UTC by Oliver Keyes
Modified: 2014-02-28 23:41 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-06-23 13:55:48 UTC
...and quite dramatically - take a look at https://en.wikipedia.org/w/index.php?title=Modified_discrete_cosine_transform&diff=561051085&oldid=558725133
Comment 1 Oliver Keyes 2013-06-23 14:03:36 UTC
Brad also has a suggestion (along with a bug report) for a workflow to make these easier to identify:

"One way to catch this for debugging purposes would be for the VisualEditor to make a note at tuntime of which sections of the article have been edited visually, for the JS code to report this to the server at save time, and then to check on the server side which sections of the article have changed in the wikitext diff. If (a) the section structure of the article remains unchanged from before the edit, and (b) there are wikitext differences in sections that have not been changed by the editor in visual mode, then something's clearly gone wrong, and the edit session should be auto-reported to the programming team. (Please don't try to use this idea as an error concealment technique: these errors shouldn't occur, as every one of them reveals some sort of bug, either in the code or the data model, and hiding them would make the software more, rather than less brittle.)"
Comment 2 James Forrester 2013-06-23 15:19:22 UTC
(In reply to comment #0)
> ...and quite dramatically - take a look at
> https://en.wikipedia.org/w/index.
> php?title=Modified_discrete_cosine_transform&diff=561051085&oldid=558725133

Eurgh. I hate being proven wrong; each of those changes fixes the (entirely-broken, but masked for users by MediaWiki) wikitext; these are the kinds of errors it's not really possible for us to re-implement.

Specifically, <i>Foo <sup>Bar</i> Baz</sup> is definitely broken HTML (mis-nested annotations), and I don't think it's necessarily a bad thing that we fix these. Obviously it'd be much better if we had a bot do a massive run over the corpus and fix these for users now, rather than have them blame VE, but that's not going to happen. :-(

Punting to Roan for thoughts, but I think this is probably a lost cause.

(In reply to comment #1)
> Brad also has a suggestion (along with a bug report) for a workflow to make
> these easier to identify:

That's going to be done in VisualEditor as part of bug 49761 (well, not that way, because VE can't objectively know what bits of the DOM it "should" have just altered unless we have a local copy of MediaWiki :-)) but yes, coming very soon, hopefully.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links