Last modified: 2013-06-24 17:10:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52054, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50054 - Parsoid: Comments inside link labels not preserved correctly
Parsoid: Comments inside link labels not preserved correctly
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-23 15:53 UTC by Ed Sanders
Modified: 2013-06-24 17:10 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ed Sanders 2013-06-23 15:53:19 UTC 
Elitre on 49608:
"Not sure if it's the same thing, but I just did this today
http://it.wikipedia.org/w/index.php?title=Google&diff=59622535&oldid=59377529
and it discarded commented text which, as noted above, should be there for a
reason :)"
Comment 1 Ed Sanders 2013-06-23 15:54:30 UTC 
Some specific examples:

[http://www.google.com Google <!-- comment text -->]
[[Main Page|Page<!-- comment text -->]]
<ref>[http://www.google.com Google <!-- comment text -->]</ref>

round trip to

[http://www.google.com Google ]<!-- comment text -->
[[Main Page|Page]]<!-- comment text -->
<ref>[http://www.google.com Google ]</ref>
Comment 2 Ed Sanders 2013-06-23 16:18:18 UTC 
This is at least partly a Parsoid bug. The first link parses to:

<p data-parsoid="{&quot;dsr&quot;:[0,52,0,0]}"><a rel="mw:ExtLink" href="http://www.google.com" data-parsoid="{&quot;targetOff&quot;:23,&quot;dsr&quot;:[0,52,23,1]}">Google </a></p><!-- comment text -->
Comment 3 Gerrit Notification Bot 2013-06-23 16:39:17 UTC 
Related URL: https://gerrit.wikimedia.org/r/70057 (Gerrit Change Ic4c5c8c8f87703e6e4fe18620075a891f8015fca)
Comment 4 Gerrit Notification Bot 2013-06-24 15:56:59 UTC 
https://gerrit.wikimedia.org/r/70057 (Gerrit Change Ic4c5c8c8f87703e6e4fe18620075a891f8015fca) | change APPROVED and MERGED [by jenkins-bot]
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links