Last modified: 2013-07-25 07:06:28 UTC
in ext.gettingstarted.taskToolbar.js, lines 127-129, we call: > var schemaAction = logging.getPageSchemaAction(); > > logging.logImpression( fullTask, schemaAction ); But 'getPageSchemaAction' can return null, and logImpression does not check for that, and the schema does not allow nulls.
We looked this up some tonight in the error logs, and it looks like this is less than 1% of events for GettingStartedNavBar, and that most of the errors are coming from the returnto funnel. We should confirm what is causing this if we can, but so far it doesn't look this would have had a big negative impact on the reliability of test results.
Related URL: https://gerrit.wikimedia.org/r/70327 (Gerrit Change I329f5992900945535fbd5431eb53f13ecddb9e4b)
It's expected actions that are not logged, such as history (there is no page-history-impression). That patch prevents it from logging if schemaAction is falsy, which should do it.
Merged.
