Last modified: 2013-07-18 22:21:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52076, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50076 - VisualEditor: Deletion into a DL from a block slug breaks
VisualEditor: Deletion into a DL from a block slug breaks
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-07-18
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-24 01:02 UTC by Oliver Keyes
Modified: 2013-07-18 22:21 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-06-24 01:02:13 UTC
Click after the line "Saptaitey Chiranjeevinaha[citation needed]" on https://en.wikipedia.org/wiki/Chiranjivi and BANG! And the text is gone.
Comment 1 James Forrester 2013-07-07 02:10:18 UTC
Yuck. Thrown error is:

  Uncaught TypeError: Object #<VeCeDefinitionListNode> has no method 'getAnnotatedHtml' 

Sounds like we didn't update the CE nodes for DLs.
Comment 2 Roan Kattouw 2013-07-10 23:43:42 UTC
DefinitionListNode shouldn't have getAnnotatedHtml, it's not inside a content branch. Did we screw up the DM such that a definition list ended up inside a paragraph?
Comment 3 Roan Kattouw 2013-07-10 23:56:04 UTC
I can't reproduce this any more, can anyone else?
Comment 4 James Forrester 2013-07-11 00:32:16 UTC
Yes; you need to backspace over the DL from the block slug underneath it to trigger.
Comment 5 Roan Kattouw 2013-07-12 19:43:47 UTC
(In reply to comment #4)
> Yes; you need to backspace over the DL from the block slug underneath it to
> trigger.
Yeah, that breaks it. For some reason handleDelete() tries to process *two* transactions: one successfully removes the entire <dl>, and the second tries to reinsert part of it but in the middle of a paragraph, presumably because it computed the wrong offset somehow (failing to adjust for the first transaction, maybe)?
Comment 6 Gerrit Notification Bot 2013-07-16 11:55:39 UTC
Change 73952 had a related patch set uploaded by Esanders:
Handle backspace correctly when in a root slug

https://gerrit.wikimedia.org/r/73952
Comment 7 Gerrit Notification Bot 2013-07-18 22:20:06 UTC
Change 73952 merged by jenkins-bot:
Handle backspace correctly when in a slugs

https://gerrit.wikimedia.org/r/73952
Comment 8 James Forrester 2013-07-18 22:21:12 UTC
Fixed and will go out in an hour.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links