Last modified: 2013-09-01 10:43:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52083, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50083 - Show-results-before-vote does not work and anons can't vote at all.
Show-results-before-vote does not work and anons can't vote at all.
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
AJAX Poll (Other open bugs)
REL1_20-branch
All All
: Normal normal (vote)
: ---
Assigned To: T. Gries
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-24 04:31 UTC by zoglun
Modified: 2013-09-01 10:43 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description zoglun 2013-06-24 04:31:30 UTC
I just update ajaxpoll to 1.84(MW 1.20.5), the show-results-before-vote does not work and anons can't vote at all.

I set the group permission like this:

$wgGroupPermissions['*']['ajaxpoll-vote'] = true;
$wgGroupPermissions['*']['ajaxpoll-view-results'] = true;
$wgGroupPermissions['sysop']['ajaxpoll-view-results-before-vote'] = true;

It return "A wrong token was received, and your vote is ignored." when not login no matter what browser I am using. 


Here is a test link:

http://zh.moegirl.org/index.php?title=Special:WikiForum&thread=277
Comment 1 zoglun 2013-06-24 05:04:23 UTC
OK, I see, show-results-before-vote figure only exist in trunk version. Even not in the 1.21 stable version.
Comment 2 T. Gries 2013-06-24 05:09:22 UTC
I am just testing your site, and wanted you to update to the master versions of both mediawiki core and the extension (the master versions do work perfectly for me, but I did not check compatibility between older versions).

Please let me know, if and what relevant AJAXPoll-relevant PHP warnings or errors are logged in your server log file.
Comment 3 T. Gries 2013-06-24 05:09:52 UTC
Thanks for reporting.
Comment 4 zoglun 2013-06-24 07:12:04 UTC
I am sorry, what do you mean master versions of Mediawiki? the newest version in git?

Just download one MW from 
https://github.com/wikimedia/mediawiki-core/tree/master 
MediaWiki 1.22alpha 
and AJAXpoll from 
https://git.wikimedia.org/zip/?r=mediawiki/extensions/AJAXPoll&format=gz

your extension do work in 1.22 now and wgGroupPermissions have overall control.

But the show-results-before-vote still have no effect on the poll at all.


Due to lots of user reporting extension error I rolled back the AJAXpoll in zh.moegirl.org.
Comment 5 T. Gries 2013-06-24 07:19:27 UTC
Yes, with "master" I do mean origin/master version in git, for MediaWiki core and for Extension:AJAXPoll.

If this combination works for you, I suggest you close the bug.
Comment 6 zoglun 2013-06-24 09:33:33 UTC
I believe the MW I got from here https://github.com/wikimedia/mediawiki-core/tree/master is the master version and the show-results-before-vote founction does not work for me. Does this extension require other special setting or extra software?
Comment 7 Andre Klapper 2013-06-24 10:18:29 UTC
if you are not sure which MW version you use, check the "Special:Version" page.
Comment 8 T. Gries 2013-08-31 11:46:15 UTC
(In reply to comment #6)
> I believe the MW I got from here
> https://github.com/wikimedia/mediawiki-core/tree/master is the master version
> and the show-results-before-vote founction does not work for me. Does this
> extension require other special setting or extra software?

Zoglun, please can you check, whether this problem reported by you is present (or not) when running the most recent mediawiki core ("HEAD") and AJAXPoll ("HEAD").

In Special:Version you see the exact version numbers, hashes and commit dates.

If it works, then please add a comment and please close this bug.
Comment 9 zoglun 2013-08-31 18:12:18 UTC
Currently using MW 1.22WMF9, the "show-results-before-vote" still not work for me.

Here is a test: http://en.moegirl.org/Sandbox

Download the newest AJAX POLL ccdd3ad	from https://git.wikimedia.org/zip/?r=mediawiki/extensions/AJAXPoll&format=gz

delete the old table of ajaxpoll_info and ajaxpoll_vote then run update.php

Wrote two vote in http://en.moegirl.org/Sandbox : 
show-results-before-vote=1
and
show-results-before-vote=0

login as user: able to see all result
as anonymous:You are not entitled to view results of this poll before you have voted.
Comment 10 T. Gries 2013-09-01 00:29:37 UTC
uh, you have to type "voting" instead of "vote"


<poll ..... show-results-before-voting=0>
...
</poll>

or

<poll ..... show-results-before-voting=1>
...
</poll>


see code lines 85
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FAJAXPoll/f60c7b3c67f1812ba15e81fe4a6e22b882cb2249/AJAXPoll_body.php


Manual page corrected.
Bug closed. (pls. reopen, if your problem still exists)
Comment 11 zoglun 2013-09-01 05:32:39 UTC
OMG this is toooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo stupid.

https://www.mediawiki.org/w/index.php?title=Extension:AJAXPoll&oldid=773306

It wrote vote for sooooooo long time.
Comment 12 T. Gries 2013-09-01 10:43:56 UTC
Zoglun:

it's not your mistake: as mentioned, I forgot to harmonise the manual page at all places, when I changed the key from show-results-before-vote to show-results-before-voting .

Perhaps I need to ask the users (like you), what of the two is better, or even to change the string another time to make it easy to remember - which is the goal.

What do you think ?
Is the present name "show-results-before-voting" okay, or should it be changed, and to what alternative ?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links