Last modified: 2013-06-25 00:28:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52113, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50113 - VisualEditor: Uses of enwiki's {{Plain image with caption}} cause alt text to be displayed as a caption
VisualEditor: Uses of enwiki's {{Plain image with caption}} cause alt text to...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-06-27
Assigned To: Inez Korczyński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-24 16:32 UTC by Oliver Keyes
Modified: 2013-06-25 00:28 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-06-24 16:32:17 UTC
See https://en.wikipedia.org/wiki/Chloroplast?veaction=edit for example.
Comment 1 James Forrester 2013-06-24 17:52:19 UTC
(In reply to comment #0)
> See https://en.wikipedia.org/wiki/Chloroplast?veaction=edit for example.

Can you say where? There's 27 images on that page and 15 of them are non-captioned images, but I don't see the alt-text coming through for them.
Comment 2 Oliver Keyes 2013-06-24 17:59:10 UTC
First image, top right; I suspect stupidity in the {{Plain image}} template.
Comment 3 James Forrester 2013-06-24 21:54:50 UTC
It looks like this is [[File:…|right|«alt text»]] is getting wrongly interpreted by Parsoid as a thumb image as opposed to a block image (which doesn't have a caption):

[[File:{{Remove file prefix|{{{1|{{{image<noinclude>|Example.svg</noinclude>}}}}}}}}|right|{{Str number/trim|{{{3|{{{width|250px}}}}}}}}px|{{{2|{{{caption<noinclude>|Caption goes here.</noinclude>}}}}}}]]

->

<figure class="mw-halign-right" typeof="mw:Image" data-parsoid="…">
  <a href="./File:Chloroplast_II.svg" data-parsoid="…"><img resource="./File:Chloroplast_II.svg" src="…" height="344" width="360" data-parsoid="…"></a>
  <figcaption class="mw-figcaption" data-parsoid="{}">Structure of a typical higher-plant chloroplast</figcaption>
</figure>

(The <figcaption> shouldn't be set, and also there should be an alt="" set.)
Comment 4 Gerrit Notification Bot 2013-06-24 22:40:30 UTC
Related URL: https://gerrit.wikimedia.org/r/70336 (Gerrit Change I24491979bc7a27d2380924e48cb677b01e9f8f9b)
Comment 5 Gerrit Notification Bot 2013-06-24 23:57:30 UTC
https://gerrit.wikimedia.org/r/70336 (Gerrit Change I24491979bc7a27d2380924e48cb677b01e9f8f9b) | change APPROVED and MERGED [by jenkins-bot]
Comment 6 James Forrester 2013-06-25 00:28:46 UTC
Gerrit change #70336 is a quick hack to fix this in VisualEditor. Parsoid bug for a proper fix (longer-term) is bug 50142.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links