Last modified: 2013-06-29 12:54:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52118, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50118 - VisualEditor: First character after a </pre> is lost on round-trip
VisualEditor: First character after a </pre> is lost on round-trip
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High critical
: VE-deploy-2013-06-27
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-24 18:26 UTC by spage
Modified: 2013-06-29 12:54 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-06-24 18:26:01 UTC
I edited a large page on meta (1.22wmf7) in VE. All seemed fine but review showed VE had removed the first character following several closing </pre> tags. It also removed a few characters within a <source> tag.

Here's the diff showing the removal, it's self-explanatory.  <https://www.mediawiki.org/w/index.php?title=Extension%3AEventLogging%2FGuide&diff=716359&oldid=704840>.  I will restore the characters by hand.
I'm using Firefox 21.0 on Kubuntu 13.04.

I tried editing the same document again and this time VE removed more characters from the source tag, added a space after a <pre>. Hmm. I'm setting to critical as it's recoverable data loss, but maybe it's intermittent.
Comment 1 James Forrester 2013-06-24 22:46:36 UTC
Making this primarily about the first character after a </pre> getting lost on round-trip; I'm not sure how you were able to edit inside a <source> tag, though, so that needs exploring too if it recurs.
Comment 2 Ed Sanders 2013-06-26 12:46:16 UTC
Can't reproduce in master.

An issue I am seeing is code inside <source> and <syntaxhighligh> blocks are losing their linebreaks. Might want to file a bug if we aren't aware of that.

Editing inside source is now bug 50224
Comment 3 James Forrester 2013-06-27 17:51:30 UTC
(In reply to comment #2)
> Can't reproduce in master.

Neither can I, in production or master. I'm going to close this as fixed, but please re-open if it recurs.
Comment 4 Helder 2013-06-29 12:54:52 UTC
Here is another example:
https://www.mediawiki.org/w/index.php?title=Gerrit/Tutorial&diff=717045

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links