Last modified: 2013-07-01 19:58:39 UTC
When doing a simple test edit on https://en.wikipedia.org/wiki/Chloroplast?veaction=edit and then previewing the diff, several transclusions of the form {{expand section|..}} show up with dirty diffs. This is very likely a DOM corruption in the VE that disables selective serialization.
Some more examples from https://en.wikipedia.org/w/index.php?namespace=&tagfilter=visualeditor&title=Special%3ARecentChanges: https://en.wikipedia.org/w/index.php?title=Eugenio_Fojo&curid=33949576&diff=561434486&oldid=561304103 https://en.wikipedia.org/w/index.php?title=Schuylar_Oordt&curid=37614262&diff=561438828&oldid=561406705
The nowiki escaping in Schuylar_Oordt is Parsoid bug 50144. It would normally be hidden with selective serialization.
*** This bug has been marked as a duplicate of bug 50070 ***
At least one {{expand section|..}} transclusion still dirty-diffs. This will soon not show up as a diff any more because we improved our native serialization, but it seems that the VE still dirties the transclusion, which needs to be fixed.
(In reply to comment #4) > At least one {{expand section|..}} transclusion still dirty-diffs. > > This will soon not show up as a diff any more because we improved our native > serialization, but it seems that the VE still dirties the transclusion, which > needs to be fixed. It doesn't seem to be dirtied by VE directly. On [[Chloroplast]], I get a clean diff if I don't make any changes, but a dirty diff if I make any change at all. This leads me to suspect a selser / DOMDiffer bug. Will try to produce a minimal test case and investigate from there.
Another example where an unmodified template was dirtied: https://en.wikipedia.org/w/index.php?title=User%3AEdgepedia%2FVE%2FGNoSR&diff=561782383&oldid=561781680 Since our DOM diff is so simple I have a lot of faith in it. Did you diff the template DOM fragment after making an unrelated change?
Another case: https://en.wikipedia.org/w/index.php?title=Dub_Jones_%28American_football%29&curid=5240085&diff=561834911&oldid=561833425
(In reply to comment #7) > Another case: > https://en.wikipedia.org/w/index. > php?title=Dub_Jones_%28American_football%29&curid=5240085&diff=561834911&oldi > d=561833425 WFM when I tried to reproduce at http://en.wikipedia.org/wiki/User:Catrope/Dub_Jones?veaction=edit . VE's sanity check says the DOM is clean. I believe these failures are due to cached content or some sort of bug in Parsoid/selser.
I don't see the Dub Jones issue any more, so that appears to be fixed. There was also an independent Parsoid issue that resulted in incomplete DSR on transclusions, which is now also fixed. If you don't see this issue any more then this bug can be closed as fixed.
