Last modified: 2013-06-25 18:08:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52138, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50138 - Jenkins: PhantomJS false QUnit test failures (compared to real browser)
Jenkins: PhantomJS false QUnit test failures (compared to real browser)
Status: RESOLVED DUPLICATE of bug 49513
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-24 22:17 UTC by spage
Modified: 2013-06-25 18:08 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-06-24 22:17:59 UTC
Extension EventLogging's qunit tests are failing in zuul+Jenkins, yet passing in both Firefox and Chromium.  See e.g.

https://integration.wikimedia.org/ci/job/mwext-EventLogging-qunit/4/consoleFull

One of the failures is "1372109891198 is a timestamp" being false.  The code in question boils down to 
    var value = new Date().getTime();

    return value instanceof Date || (
            typeof value === 'number' &&
            value >= 0 &&
            value % 1 === 0 );
which seems legit.

in my phantomjs 1.6.0 (old version) REPL loop,
   value = new Date().getTime();
prints
  'value = new Date.getTime();' is a cyclic structure

Maybe this is the cause.  If so, a workaround is to use
  value = (new Date()).getTime();

I haven't looked at the other error cases.
Comment 1 spage 2013-06-24 22:20:04 UTC
Not sure if the component should beQA or Continuous Integration.
Comment 2 Krinkle 2013-06-24 22:22:40 UTC
It runs tests in PhantomJS which uses a slightly outdated version of WebKit and JavaScriptCore. If this is failing there, it is likely failing in old WebKit for real.

In general this should be a bug against the component where the test resides as a todo to fix it in the code because there's nothing we can realistically do about it from our end.
Comment 3 Ori Livneh 2013-06-24 22:39:31 UTC

*** This bug has been marked as a duplicate of bug 49513 ***
Comment 4 Antoine "hashar" Musso (WMF) 2013-06-25 18:08:37 UTC
(In reply to comment #1)
> Not sure if the component should beQA or Continuous Integration.

Anything triggered by Zuul would fall under Continuous Integration.  QA is more about Selenium tests and leading the overall QA effort of which CI is just a "tiny" part :-)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links