Last modified: 2013-06-28 00:58:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52141, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50141 - VisualEditor: Indentation toolbar buttons should not be enabled by default
VisualEditor: Indentation toolbar buttons should not be enabled by default
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-07-04
Assigned To: Rob Moen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-24 23:18 UTC by Krinkle
Modified: 2013-06-28 00:58 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-06-24 23:18:34 UTC
They're currently enabled on page load. Even when dismissing the notice and clicking around in the first paragraph it stays.

It finally disables itself after a node change (e.g. click the second paragraph and then back).
Comment 1 Krinkle 2013-06-25 07:02:59 UTC
From conversation earlier today:

It may be possible to hack the button to be disabled by default, but that would introduce the opposite bug where the indention tool would be disabled instead of enabled in a document that starts with a list, requiring the user to move out of the list and back in to be able to indent.

Basically we should make sure that our hooks that make the button enabled/disabled on node focus change also trigger when initially focussing the first node in the document (instead of only from the second node focus onwards).
Comment 2 Gerrit Notification Bot 2013-06-27 23:17:52 UTC
Change 70936 had a related patch set uploaded by Robmoen:
Init surface after toolbar is setup vs. before.

https://gerrit.wikimedia.org/r/70936
Comment 3 Gerrit Notification Bot 2013-06-27 23:23:39 UTC
Change 70936 merged by jenkins-bot:
Init surface after toolbar is setup vs. before.

https://gerrit.wikimedia.org/r/70936
Comment 4 James Forrester 2013-06-28 00:58:16 UTC
This has been fixed and will be deployed very soon.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links