Last modified: 2014-07-15 07:31:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52166, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50166 - Default whitespace for block templates should be to have a \n beforehand


Summary:	Default whitespace for block templates should be to have a \n beforehand

Status:	NEW

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Gabriel Wicke

URL:
Whiteboard:
Keywords:

Duplicates:	67268 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-06-25 10:29 UTC by This, that and the other (TTO)
Modified:	2014-07-15 07:31 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description This, that and the other (TTO) 2013-06-25 10:29:49 UTC

In this revision (normal output, not VE), the navbox looks bugged because it is sitting on the same line as a list item:

http://en.wikipedia.org/w/index.php?title=History_of_Delta_Air_Lines&oldid=561463069#External_links

But VE shows the navbox as if it was on its own line.

This display fault caused a user to save the revision in question, thinking it was formatted properly. VE should probably be leaving block templates on their own line. (Is that another bug?)

Comment 1 James Forrester 2013-07-07 01:30:11 UTC

Retitled this to a Parsoid bug, "Default whitespace for block templates should be to have a \n beforehand" which would solve the issue - but I'm not sure how easy that is for Parsoid to implement?

Comment 2 Gabriel Wicke 2013-07-09 03:13:45 UTC

Is there TemplateData info on what is a block template, and would it be fine to enforce that?

Comment 3 James Forrester 2013-07-09 03:19:29 UTC

(In reply to comment #2)
> Is there TemplateData info on what is a block template, and would it be fine
> to enforce that?

We could add it, but some templates are block or inline depending on parameters, so…

Comment 4 Gabriel Wicke 2013-07-09 03:23:46 UTC

… or the phase of the moon.

Comment 5 This, that and the other (TTO) 2014-07-15 07:30:35 UTC

*** Bug 67268 has been marked as a duplicate of this bug. ***

Comment 6 This, that and the other (TTO) 2014-07-15 07:31:11 UTC

Bug 50166 contains a nice example of where this is really important (templates that generate table markup like |- etc).

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links