Last modified: 2013-08-22 22:09:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52179, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50179 - Parsoid: Round trip bug with apostrophe next to italics
Parsoid: Round trip bug with apostrophe next to italics
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-25 14:47 UTC by Ed Sanders
Modified: 2013-08-22 22:09 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2013-06-25 14:47:42 UTC
<i>Rolling Stone</i>'s

serialises to:

'''Rolling Stone'''s

which then converts back to

<i>Rolling Stone'</i>s

In both Parsoid & PHP parser, with the apostrophe now italicised.
Comment 1 Gerrit Notification Bot 2013-06-25 22:17:32 UTC
Related URL: https://gerrit.wikimedia.org/r/70554 (Gerrit Change I1e47c651324f40d7ff562f0eeb6f19bd6989ffd2)
Comment 2 Gerrit Notification Bot 2013-06-26 04:49:35 UTC
https://gerrit.wikimedia.org/r/70554 (Gerrit Change I1e47c651324f40d7ff562f0eeb6f19bd6989ffd2) | change APPROVED and MERGED [by jenkins-bot]
Comment 3 Ed Sanders 2013-06-26 12:24:32 UTC
We still have a minor round trip issue where

''Rolling Stone'''s

round trips to

''<nowiki>Rolling Stone'</nowiki>''s

Although the latter is arguably much better, it is still a dirty diff.
Comment 4 Gabriel Wicke 2013-06-26 15:05:15 UTC
When the <i> and its subtree is unmodified, selective serialization avoids dirty diffs. So in any case the diff will be very localized.

Because of the complex heuristics used in quote handling it will be difficult to avoid nowikis altogether for modified or new content. We can try to serialize this as ''Rolling Stone'<nowiki/>''s though.
Comment 5 Gabriel Wicke 2013-07-02 01:29:13 UTC
Actually, ''Rolling Stone''<nowiki/>'s is the desired serialization.
Comment 6 ssastry 2013-08-22 22:09:05 UTC
This has already been fixed at some point in the last 6 weeks.

[subbu@earth tests] echo "<i>Rolling Stone</i>'s" | node parse --html2wt
''Rolling Stone''<nowiki/>'s

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links