Last modified: 2014-10-02 00:22:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52197, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50197 - VisualEditor: Make ve.ui.PopupWidget#display signature not insane
VisualEditor: Make ve.ui.PopupWidget#display signature not insane
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-25 20:28 UTC by Krinkle
Modified: 2014-10-02 00:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2013-06-25 20:28:06 UTC 
3 parameters is the limit, 6 is crazy.

ve.ui.PopupWidget.prototype.display = function ( x, y, width, height, transition, embedded ) {
Comment 1 Krinkle 2014-10-02 00:22:45 UTC 
Looking pretty good. It's been separated and the method itself (OO.ui.PopupWidget#display) no longer exists.

https://github.com/wikimedia/oojs-ui/blob/e43584b420/src/widgets/PopupWidget.js
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links