Last modified: 2013-06-26 15:28:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52208, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50208 - VisualEditor: Possible to have links nested inside links
VisualEditor: Possible to have links nested inside links
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-06-27
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-26 04:21 UTC by This, that and the other (TTO)
Modified: 2013-06-26 15:28 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description This, that and the other (TTO) 2013-06-26 04:21:40 UTC
(Sorry for carelessly filing a dupe before (bug 50207) - I have checked this one, but if it is a dupe, you are most welcome to trout me for wasting your time!)

1. Edit [[testwiki:VisualEditor:Links]] in VE
2. Make a selection like

     Golden Gate National Recreation [Area is the] best

   (partly inside the link, partly outside it)
3. Click the "Link" toolbar button and make a link to any page
4. Click in the word "Area" to move the cursor there

Two link icons appear in the floating toolbar.

5. Save page > Review changes

Wikitext output has two links side-by-side, pointing to the same target.
Comment 1 James Forrester 2013-06-26 04:35:03 UTC
(In reply to comment #0)
> (Sorry for carelessly filing a dupe before (bug 50207) - I have checked this
> one, but if it is a dupe, you are most welcome to trout me for wasting your
> time!)

Ha, no worries; dupe's aren't in any way useless (it reminds us that it's a real problem we need to fix really soon!). It's mostly just that it's a waste of your time. :-(

> 
> 1. Edit [[testwiki:VisualEditor:Links]] in VE
> 2. Make a selection like
> 
>      Golden Gate National Recreation [Area is the] best
> 
>    (partly inside the link, partly outside it)
> 3. Click the "Link" toolbar button and make a link to any page
> 4. Click in the word "Area" to move the cursor there
> 
> Two link icons appear in the floating toolbar.
> 
> 5. Save page > Review changes
> 
> Wikitext output has two links side-by-side, pointing to the same target.

Yeah, this is definitely a fail on our part (and a regression!). Thanks for the spot; assigning to Ed.
Comment 2 Gerrit Notification Bot 2013-06-26 15:22:23 UTC
Related URL: https://gerrit.wikimedia.org/r/70644 (Gerrit Change I1cab7f3cc4fc9589eced01ad38c59fe5b9622a57)
Comment 3 James Forrester 2013-06-26 15:28:27 UTC
Merged and we'll push this to production in the next hour or so.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links