Last modified: 2014-04-04 20:15:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52225, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50225 - VisualEditor: Non-primary edit tab <li> should have class="collapsible"
VisualEditor: Non-primary edit tab <li> should have class="collapsible"
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-04-10
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-26 13:03 UTC by Guillaume Paumier
Modified: 2014-04-04 20:15 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot: Narrow window (10.21 KB, image/png)
2013-06-26 13:03 UTC, Guillaume Paumier
Details
Screenshot: High zoom (25.65 KB, image/png)
2013-06-26 13:04 UTC, Guillaume Paumier
Details

Description Guillaume Paumier 2013-06-26 13:03:48 UTC
Created attachment 12642 [details]
Screenshot: Narrow window

When space is scarce (for example at high zoom, or when the window is very narrow), the "View history" tab is moved to the drop-down menu (that also includes "Delete", "Move", etc.) so that the action remains accessible.

The "Edit" and "Edit source" tabs don't seem to do the same; they stay where they are, which prevents them from being used in similar situations (see attached screenshots).

It would imho make sense to migrate both tabs to the drop-down menu as well when there isn't enough space to display them at their usual location, so that users can still access the edit modes.
Comment 1 Guillaume Paumier 2013-06-26 13:04:17 UTC
Created attachment 12643 [details]
Screenshot: High zoom
Comment 2 Bartosz Dziewoński 2013-06-26 13:07:05 UTC
(In reply to comment #0)
> It would imho make sense to migrate both tabs to the drop-down menu as well
> when there isn't enough space to display them at their usual location, so
> that
> users can still access the edit modes.

"Edit" is not normally collapsed, but it would make sense for "Edit source". You'd just add class="collapsible" on the <li> and it will magically work.
Comment 3 Gerrit Notification Bot 2014-04-03 01:17:03 UTC
Change 123503 had a related patch set uploaded by Alex Monk:
Give the edit tab <li> closest to the collapsed tabs menu class=collapsible

https://gerrit.wikimedia.org/r/123503
Comment 4 Gerrit Notification Bot 2014-04-04 19:32:23 UTC
Change 123503 merged by jenkins-bot:
Give the edit tab <li> closest to the collapsed tabs menu class=collapsible

https://gerrit.wikimedia.org/r/123503

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links