Last modified: 2013-07-04 10:33:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52238, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50238 - Parsoid round-trips pipes in templated external link target to |


Summary:	Parsoid round-trips pipes in templated external link target to \|

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	---
Assigned To:	Gabriel Wicke

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-06-26 15:58 UTC by Roan Kattouw
Modified:	2013-07-04 10:33 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-06-26 15:58:27 UTC

http://parsoid.wmflabs.org/_rt/en/Ya_Know%3F

Comment 1 Gabriel Wicke 2013-06-26 16:02:03 UTC

Does not apply to nested templates in general:
echo '{{echo|{{echo|a|b}}}}' | node parse --wt2wt
{{echo|{{echo|a|b}}}}

Minimal test case:
echo '{{echo|[{{echo|http://example.com}} Foo]}}' | node parse --wt2wt
{{echo|[{{echo&#124;http://example.com}} Foo]}}

Comment 2 Gerrit Notification Bot 2013-06-28 22:22:52 UTC

Change 71140 had a related patch set uploaded by GWicke:
Bug 50238: Don't entity-escape pipes in extlinks

https://gerrit.wikimedia.org/r/71140

Comment 3 Gerrit Notification Bot 2013-06-29 06:07:58 UTC

Change 71140 merged by jenkins-bot:
Bug 50238: Don't entity-escape pipes in extlinks

https://gerrit.wikimedia.org/r/71140

Comment 4 Gabriel Wicke 2013-06-29 06:13:18 UTC

Not a perfect fix (we are not escaping everything in nested transclusions that we should), but at least it lets experienced editors do what they need to do. They are less likely to mess up, hopefully.

Comment 5 Andre Klapper 2013-07-04 10:33:07 UTC

[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links