Last modified: 2013-10-06 14:37:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52288, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50288 - Fatal error when using invalid target page title
Fatal error when using invalid target page title
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: s7eph4n
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-27 14:10 UTC by s7eph4n
Modified: 2013-10-06 14:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description s7eph4n 2013-06-27 14:10:37 UTC
If the form generates an invalid target page name, then

 $target_title = Title::newFromText( preg_replace( '/{num.*}/', $title_number, $targetName ) );

in SF_AutoeditAPI::generateTargetName() (line 677) will return null, which will result in a fatal error (Call to a member function on a non-object) in the following loop.

Solution: Throw an error ("Invalid target page name $name") if Title::newFromText() returns null.
Comment 1 Gerrit Notification Bot 2013-10-03 20:05:06 UTC
Change 87441 had a related patch set uploaded by Foxtrott:
fix bug 50288 (Fatal error when using invalid target page title)

https://gerrit.wikimedia.org/r/87441
Comment 2 Gerrit Notification Bot 2013-10-03 20:52:41 UTC
Change 87441 had a related patch set uploaded by Siebrand:
fix bug 50288 (Fatal error when using invalid target page title)

https://gerrit.wikimedia.org/r/87441
Comment 3 Gerrit Notification Bot 2013-10-06 13:42:10 UTC
Change 87441 merged by jenkins-bot:
Fix fatal error when using invalid target page title

https://gerrit.wikimedia.org/r/87441

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links