Last modified: 2013-07-03 12:13:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52299, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50299 - UI does not prevent multiple sitelinks to same target site.
UI does not prevent multiple sitelinks to same target site.
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest blocker (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-27 16:39 UTC by Daniel Kinzler
Modified: 2013-07-03 12:13 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2013-06-27 16:39:29 UTC
When adding a sitelink, it should be impossible to add a second site link to the same site (or: to the same language in the same group). Currently, the UI does not prevent this, and saving fails silently (the link appears to be added until the page is reloaded). This problem exists even if there is only one site group.

The issue here is twofold: 

a) the UI should prevent multiple sitelinks to the same site (this constraint can be enforced regardless of site groups)

b) the API should respond with an error when trying to set a site link to a site that is already covered.
Comment 1 Daniel Kinzler 2013-06-27 17:06:14 UTC
Correction: when adding a second link to the same site, the new links will replace the old link. Upon reloading the page, one the newly set link wfor that site will remain.

The API is behaving correctly: the wbsetsitelink module is defined to replace any existing links to the given site.

It's the responsibility of the UI to prevent sitelinks being replaced that way.
Comment 2 Henning 2013-07-03 10:24:41 UTC
https://gerrit.wikimedia.org/r/#/c/70988/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links