Last modified: 2013-06-27 17:21:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52300, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50300 - Gerrit no longer supports --force-message option
Gerrit no longer supports --force-message option
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Immediate major (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-27 17:12 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-06-27 17:21 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2013-06-27 17:12:28 UTC
The gate-and-submit Zuul pipeline is configured to send a review to Gerrit with --force-message .  This is needed to make sure the build result is sent back to Gerrit even if the change has already been merged.

The Zuul stack trace is:


2013-06-27 16:59:09,034 DEBUG gerrit.Gerrit: SSH received stderr:
fatal: "--force-message" is not a valid option

2013-06-27 16:59:09,034 ERROR zuul.IndependentPipelineManager: Exception while reporting:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/zuul-ac3ba4f-py2.7.egg/zuul/scheduler.py", line 899, in reportChange
    ret = self.sched.trigger.report(change, report, action)
  File "/usr/local/lib/python2.7/dist-packages/zuul-ac3ba4f-py2.7.egg/zuul/trigger/gerrit.py", line 142, in report
    message, action)
  File "/usr/local/lib/python2.7/dist-packages/zuul-ac3ba4f-py2.7.egg/zuul/lib/gerrit.py", line 126, in review
    out, err = self._ssh(cmd)
  File "/usr/local/lib/python2.7/dist-packages/zuul-ac3ba4f-py2.7.egg/zuul/lib/gerrit.py", line 178, in _ssh
    raise Exception("Gerrit error executing %s" % command)
Exception: Gerrit error executing gerrit review --project mediawiki/extensions/AbuseFilter --message "Build succeeded.

- https://integration.wikimedia.org/ci/job/mwext-AbuseFilter-merge/220/console : SUCCESS in 5s
- https://integration.wikimedia.org/ci/job/mwext-AbuseFilter-lint/219/console : SUCCESS in 1s
" --verified 2 --force-message --submit --code-review 0 70767,4


Effect: Zuul no more merge anything for us :D

A workaround is to remove the 'force-message: true' in Zuul layout configuration.
Comment 1 Antoine "hashar" Musso (WMF) 2013-06-27 17:18:44 UTC
https://gerrit.wikimedia.org/r/70849
Comment 2 Antoine "hashar" Musso (WMF) 2013-06-27 17:18:54 UTC
Removed by Gerrit upstream :(
Comment 3 Antoine "hashar" Musso (WMF) 2013-06-27 17:21:44 UTC
That fixed the issue.

https://gerrit.wikimedia.org/r/#/c/70767/ got merged after a +2

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links