Last modified: 2013-07-04 09:59:40 UTC
When opening patch pages like https://gerrit.wikimedia.org/r/#/c/70826/, Firefox remains in 'Working...' state forever. Cache clearing does not help. There are no errors in the JS console. Version: Mozilla/5.0 (X11; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0 Iceweasel/20.0 It *does* works in Firefox Aurora (dev version) on Android.
After upgrading to Mozilla/5.0 (X11; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0 Iceweasel/22.0 which just hit Debian experimental the issue is gone. Chad indicated that it works for him using either 21 or 22, so it seems to be an issue in 20 and possibly lower.
Some pages work for me, and some don't. The search always works, and viewing some changes works, but viewing other changes (especially ones with a lot of patchsets where I am a reviewer) is broken. It only breaks in Firefox (using 21.0), not in Chrome, and it only breaks when I'm logged in. Error message from the console: http://pastebin.com/h4YPhskV
Subbu experiences similar issues with FF 22. Maybe a cache / localstorage issue after all?
(In reply to comment #3) > Subbu experiences similar issues with FF 22. Maybe a cache / localstorage > issue > after all? Looks like it might be that. I just opened a private window and logged into Gerrit there, and it was fine. Will try clearing all cookies and storage for gerrit.wm.o
I'm getting this issue again despite upgrading to 22. I only happens on a particular patch page. Error in JS console: [13:10:00.110] Thu Jun 27 13:10:00 GMT-700 2013 Class$3 SEVERE: (TypeError) stack: Exb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1851 Exb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1851 Exb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1851 Jxb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2968 Vm@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1487 G9@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2965 A9@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2965 LU@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2832 jP@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2940 ZP@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2965 pab@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2513 yab@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2965 dcb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2965 RZb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2499 p$b@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2971 c.onreadystatechange<@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1861 mPb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1310 pPb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2634 @https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2055 fileName: https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html lineNumber: 1851 columnNumber: 22: a is null Class$S1189: (TypeError) stack: Exb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1851 Exb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1851 Exb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1851 Jxb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2968 Vm@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1487 G9@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2965 A9@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2965 LU@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2832 jP@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2940 ZP@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2965 pab@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2513 yab@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2965 dcb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2965 RZb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2499 p$b@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2971 c.onreadystatechange<@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1861 mPb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:1310 pPb@https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2634 @https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html:2055 fileName: https://gerrit.wikimedia.org/r/gerrit_ui/03A71ECCC583E00F100128463FE52FD6.cache.html lineNumber: 1851 columnNumber: 22: a is null at Unknown.Exb(Unknown Source) at Unknown.Exb(Unknown Source) at Unknown.Exb(Unknown Source) at Unknown.Jxb(Unknown Source) at Unknown.Vm(Unknown Source) at Unknown.G9(Unknown Source) at Unknown.A9(Unknown Source) at Unknown.LU(Unknown Source) at Unknown.jP(Unknown Source) at Unknown.ZP(Unknown Source) at Unknown.pab(Unknown Source) at Unknown.yab(Unknown Source) at Unknown.dcb(Unknown Source) at Unknown.RZb(Unknown Source) at Unknown.p$b(Unknown Source) at Unknown.c.onreadystatechange<(Unknown Source) at Unknown.mPb(Unknown Source) at Unknown.pPb(Unknown Source) at Unknown.anonymous(Unknown Source) at Unknown.anonymous(Unknown Source)
I've been hitting this issue today on 21. It's quite common, but not on every load (I can get through sometimes): Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0 Iceweasel/21.0
I tried some Firefoxes from 13.0 upwards. For me clearing caches and forcing reload reliably solved the issue of pages not finishing. (In reply to comment #5) > I'm getting this issue again despite upgrading to 22. I only happens on a > particular patch page. Error in JS console: Comment #5 looks like a separate problem. What's the particular URL you experience this on? Could you file a separate bug for that and attach the output of the JS error console for that page in debug mode? (To switch to debug mode, just set the URL parameter dbg to 1. So for example instead of https://gerrit.wikimedia.org/r/#/c/70826/ use https://gerrit.wikimedia.org/r/?dbg=1#/c/70826/ . That variant uses readable JS)
(In reply to comment #7) > I tried some Firefoxes from 13.0 upwards. For me clearing caches and forcing > reload reliably solved the issue of pages not finishing. That should have been: * Logging out, * clearing caches, * logging in again, * forcing reload.
We just had a report that logging out and in again was required twice on Firefox 20. Then it worked again. (When logged out, the change loaded without any problem)
Seeing the priority got bumped to High ... I'd rather close this bug. The problem stems from upgrading gerrit. People are simply having documents from the old gerrit in the browser cache. Typically, gerrit upgrades behave nicer. But this was really a major upgrade. Buck switched their build system so the JS gets built differently etc. I've been asked several times on IRC about this problem, and the above procedure always fixed the problem reliably. So to me, it's not a problem of the old or the new gerrit, it's just a problem of the user's browser caches. There is little we can do, except helping users to reload gerrit in their browser :-/
(In reply to comment #10) > I've been asked several times on IRC about this problem, and the above > procedure always fixed the problem reliably. So to me, it's not a problem > of the old or the new gerrit, it's just a problem of the user's browser > caches. If it's simply static content (JS/CSS), that can be solved with either an appropriate cache duration, or unique static content filenames for every Gerrit version (or perhaps every JS/CSS minification) If it's cookies/localStorage/etc., those can be versioned. If Gerrit sees an old cookie or localStorage, it should simply delete it and do the normal empty cache behavior. Asking people (only those who found this Bugzilla bug) to clear their cache manually is a temporary workaround, not an permanent solution.
This might need to be filed upstream.
(In reply to comment #8) > (In reply to comment #7) > > I tried some Firefoxes from 13.0 upwards. For me clearing caches and forcing > > reload reliably solved the issue of pages not finishing. > > That should have been: > * Logging out, > * clearing caches, > * logging in again, > * forcing reload. This procedure doesn't work for me...
(In reply to comment #9) > We just had a report that logging out and in again was required twice on > Firefox 20. Then it worked again. > > (When logged out, the change loaded without any problem) Well doing it twice made gerrit work for me :)
(In reply to comment #14) > (In reply to comment #9) > > We just had a report that logging out and in again was required twice on > > Firefox 20. Then it worked again. > > > > (When logged out, the change loaded without any problem) > > Well doing it twice made gerrit work for me :) But on Firefox 21 instead of 20. Sorry for missing it in the first comment.
(In reply to comment #14) > (In reply to comment #9) > > We just had a report that logging out and in again was required twice on > > Firefox 20. Then it worked again. > > > > (When logged out, the change loaded without any problem) > > Well doing it twice made gerrit work for me :) Hmm ... it stops working again today. Weird.
I did the following: 1. Deleted the GerritAccount cookie (de facto logging myself out), which is the only cookie. 2. Used the Firefox "Clear Recent History" dialog, selecting "Everything" (no time constraint" and checking "Cache" and "Offline Website Data" (as it happens, this includes all sites, not just Gerrit). 3. Logged back in. 4. It showed Working and no page. I let it run like that for 10 minutes with no change. This is still Iceweasel/Firefox 21.0.
We tried flushing all the on-disk caches this morning, doesn't seem to have helped :\
Just hit this issue again on a random patch page. Logging out twice helped for the moment, as did ?dbg=1.
We did some tests with Siebrand this morning (thanks for your help!) and we narrowed the problem a bit. We're pretty sure it's a problem in GWT's Javascript obfuscation. We're going to try re-building without the obfuscation for Firefox users, we *think* this will solve it. We're going to press upstream harder on this, because I'm thinking it's a bug in GWT itself.
Issue is now resolved on the Wikimedia instance. Thanks Christian and Chad for allowing me to be your tool to find out what was going on.
Should this be marked dupe of bug 45267 ?
Confirming it's finally fixed for me. Closing.
