Last modified: 2014-05-20 14:49:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52327, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50327 - Zuul: should report pipeline name in build status message
Zuul: should report pipeline name in build status message
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Low enhancement (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-27 22:35 UTC by spage
Modified: 2014-05-20 14:49 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-06-27 22:35:50 UTC
It would be clearer if jenkins-bot's comments on gerrit changes named the pipeline involved, particularly when a change triggers multiple jobs.  For example a branch commit that you immediately +2, such as https://gerrit.wikimedia.org/r/#/c/70910/ , seems to generates an initial check-in job, a "+2d-so-maybe-merge" job, and a post-merge doxgen job.

  jenkins-bot	Patch Set 1: Verified+2 Build succeeded. - …
  jenkins-bot	Patch Set 1: -Verified Starting gate-and-submit …
  jenkins-bot	Change has been successfully merged into the git repository.
  jenkins-bot	Patch Set 1: Verified+2 Build succeeded. - …
  jenkins-bot	Patch Set 1: Build failed. - …

It's hard to tell these jobs apart, hard to tell whether the "Starting gate-and-submit" succeeded/failed/continues, and the '-' is a mystery. The workaround is to expand the comments and look at the group of CI tasks run to infer what kind of job succeeded or failed; or be intimately familiar with all the Zuul pipelines.  This seems better:
  jenkins-bot	Patch Set n: <pipeline name> build [succeeded.|FAILED!]

where I think from https://integration.wikimedia.org/zuul/ the pipeline names are <check-only check-voter gate gate-and-submit gate-silent post postmerge publish test>.


(BTW the last comment in the example is doxygen failing on a branch, bug 50325)
Comment 1 Antoine "hashar" Musso (WMF) 2013-06-28 08:42:32 UTC
This bug report is a follow up to a conversation I had with S on IRC.  It is indeed confusing to users when jenkins-bot 'spam' comments on a bug, you barely know what has been tested.

Adding the pipeline name in the message would indeed make it easier to track what is going on.
Comment 2 Antoine "hashar" Musso (WMF) 2013-06-28 08:44:15 UTC
This can be done in the layout.yaml configuration, each pipeline message can be overridden with 'failure-message' and 'success-message' statements.
Comment 3 Antoine "hashar" Musso (WMF) 2013-07-05 12:57:43 UTC
Made possible with Zuul change https://review.openstack.org/#/c/19677/
Comment 4 Gerrit Notification Bot 2014-01-15 13:35:58 UTC
Change 107570 had a related patch set uploaded by Hashar:
explicitly define success/failure messages

https://gerrit.wikimedia.org/r/107570
Comment 5 Gerrit Notification Bot 2014-01-15 13:36:16 UTC
Change 107570 merged by jenkins-bot:
explicitly define success/failure messages

https://gerrit.wikimedia.org/r/107570
Comment 6 Antoine "hashar" Musso (WMF) 2014-01-15 13:37:17 UTC
We have upgraded Zuul last week. Gerrit change #107570 introduces default success/failures messages to all our pipelines.  Anyone can thus tweak them as needed.
Comment 7 Gerrit Notification Bot 2014-05-19 15:12:46 UTC
Change 134098 had a related patch set uploaded by Hashar:
Report pipeline name in build status message

https://gerrit.wikimedia.org/r/134098
Comment 8 Gerrit Notification Bot 2014-05-20 14:48:13 UTC
Change 134098 merged by jenkins-bot:
Report pipeline name in build status message

https://gerrit.wikimedia.org/r/134098
Comment 9 Antoine "hashar" Musso (WMF) 2014-05-20 14:49:51 UTC
Change deployed and Zuul reloaded.  We can tweak the message latter on since good placeholders are already in place.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links