Last modified: 2013-07-30 10:07:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52331, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50331 - VisualEditor throws <nowiki> next to any square bracket [
VisualEditor throws <nowiki> next to any square bracket [
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-27 23:15 UTC by Quim Gil
Modified: 2013-07-30 10:07 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quim Gil 2013-06-27 23:15:11 UTC
It is usual to use [square brackets], [...] inside quotes to cut or complete sentences in quotes. As for today, VisualEditor will add <nowiki> tags like this:

<nowiki>[Square brackets]</nowiki>

<nowiki>[...]</nowiki>

This is not a big deal since the users will keep seeing the same in the published article, but it adds unnecessary cruft in edit source mode and it's wrong.

Also, according to Bug 47678 this means that editors won't be able to edit the content inside those brackets with VisualEditor, because of the <nowiki> tags.
Comment 1 Gabriel Wicke 2013-07-02 05:53:52 UTC
We have refined the nowiki escaping in Parsoid so that external link like syntax that does not have a valid target is no longer escaped.
Comment 2 Jan Eissfeldt 2013-07-02 07:06:07 UTC
Looks like we are either still have a problem or it may have resurfaced; last section of:

http://en.wikipedia.org/w/index.php?title=Raphael_Sch%C3%A4fer&diff=prev&oldid=562506378

and follow up edits.
Comment 4 Gabriel Wicke 2013-07-02 14:56:43 UTC
This bug was about single square brackets ([ ... ]), not wikitext links. 

Entering [[Foo]] as text will practically always need to be escaped as the rules for valid page titles are less restrictive than those for absolute URLs. Same is true for linking parts of a word where the remainder of the word would become part of the link via the link trail mechanism (aka- less precisely- 'piped links'). Or entering any other random wikitext in the VE. Not escaping such wikitext would break the WYSIWYG promise.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links