Last modified: 2014-07-03 03:02:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52341, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50341 - VisualEditor: Title is not updated on save if DISPLAYTITLE changed
VisualEditor: Title is not updated on save if DISPLAYTITLE changed
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-07-03
Assigned To: Alex Monk
:
Depends on: 56868
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-28 03:16 UTC by This, that and the other (TTO)
Modified: 2014-07-03 03:02 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Wrong title displayed in "correct title" template. (338.54 KB, image/jpeg)
2013-06-29 20:26 UTC, Elitre
Details

Description This, that and the other (TTO) 2013-06-28 03:16:15 UTC
1. Edit [[testwiki:Displaytitle]] using VE
2. Using the transclusion dialog box, add the following "template":
        DISPLAYTITLE:''displaytitle''
3. Save the page

The page title remains "Displaytitle" in roman type.

Expected to see "displaytitle" in italics. This is what you see when you refresh the page.
Comment 1 Elitre 2013-06-29 20:26:49 UTC
Created attachment 12689 [details]
Wrong title displayed in "correct title" template.

I think it's related, so I'm sticking this here.

After http://it.wikipedia.org/w/index.php?title=Utente:Dry_Martini/Cricca&diff=prev&oldid=59761793, the page, containing a "Correct title" template, would display, after being saved, the message usually generated by that template, although it disappears if you refresh. 

I tried it myself and this time I actually changed the title in the template.
The screenshot shows what happened after http://it.wikipedia.org/w/index.php?title=Utente%3ADry_Martini%2FCricca&diff=59761896&oldid=59761793 my edit.
Basically, the page retains its formerly given title, while displaying in the message the one I chose. Again, everything is ok if you refresh.
(For the record, the usual title is "There is no Cabal", while mine reads "There's a Cabal, and it's using VisualEditor".)
Comment 2 pamdavies7 2013-07-02 15:21:42 UTC
I think this includes my problem with {{tl|italic title}}, which is at two levels:
# When I add it, I expect to see it take effect immediately - it doesn't (so I wonder whether I remembered to add it, whether I formatted it correctly, ... etc)
# Even when I save the page, it doesn't take effect until I refresh the page (same set of worries).
Comment 3 John Mark Vandenberg 2013-07-17 05:54:42 UTC
Confirmed that adding italics to an existing page doesnt display italics on save - it does display the italic title after save + refresh.

However it does display italics on save, if the DISPLAYTITLE is set for a new page. 

Tested with {{italics title}} and {{DISPLAYTITLE:''ItalicsTitle''}} on testwiki

https://test.wikipedia.org/wiki/ItalicsTitle
Comment 4 Alex Monk 2014-06-12 16:27:38 UTC
So now that the dependency is merged, Parsoid now recognises {{DISPLAYTITLE:stuff}} as a meta property (instead of a template), and VE provides a box on the options page to change the display title. I think what we should do is update the title (almost) as soon as it's changed.
Comment 5 Alex Monk 2014-06-12 21:17:23 UTC
Yeah it's actually kind of a pain to do that. Let's update it on save.
Comment 6 Gerrit Notification Bot 2014-06-12 21:18:37 UTC
Change 139205 had a related patch set uploaded by Alex Monk:
Update displaytitle on save

https://gerrit.wikimedia.org/r/139205
Comment 7 Gerrit Notification Bot 2014-06-18 02:23:30 UTC
Change 139205 merged by jenkins-bot:
Update displaytitle on save

https://gerrit.wikimedia.org/r/139205
Comment 8 James Forrester 2014-06-18 20:21:59 UTC
Patch reverted; re-opening.
Comment 9 Gerrit Notification Bot 2014-06-18 23:17:47 UTC
Change 140591 had a related patch set uploaded by Alex Monk:
Update displaytitle on save (try #2)

https://gerrit.wikimedia.org/r/140591
Comment 10 Gerrit Notification Bot 2014-06-18 23:41:31 UTC
Change 140591 merged by jenkins-bot:
Update displaytitle on save (try #2)

https://gerrit.wikimedia.org/r/140591
Comment 11 Gerrit Notification Bot 2014-06-23 15:32:17 UTC
Change 141098 had a related patch set uploaded by Alex Monk:
Update displaytitle on save (try #3)

https://gerrit.wikimedia.org/r/141098
Comment 12 Gerrit Notification Bot 2014-07-01 21:18:56 UTC
Change 141098 merged by jenkins-bot:
Update displaytitle on save (try #3)

https://gerrit.wikimedia.org/r/141098
Comment 13 Alex Monk 2014-07-01 21:42:43 UTC
So this appears to actually be working now.
Comment 14 James Forrester 2014-07-03 03:02:40 UTC
(In reply to Alex Monk from comment #13)
> So this appears to actually be working now.

Woo-hoo. :-)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links