Last modified: 2014-03-18 03:05:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52356, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50356 - VisualEditor: Edits triggering CAPTCHA cannot be saved
VisualEditor: Edits triggering CAPTCHA cannot be saved
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High critical
: VE-deploy-2013-07-04
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-28 10:01 UTC by This, that and the other (TTO)
Modified: 2014-03-18 03:05 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description This, that and the other (TTO) 2013-06-28 10:01:07 UTC
On a CAPTCHA-triggering edit, VE does not display the CAPTCHA, instead showing an alert:

Error saving data to server: Failed request: error.

Marking critical, because VE is in use by 50% of new users at enwiki, none of whom are now able to add external links for sourcing purposes.
Comment 1 This, that and the other (TTO) 2013-06-28 12:32:38 UTC
(In reply to comment #0)
> Error saving data to server: Failed request: error.

The same error is also seen when triggering the spam blacklist.
Comment 2 James Forrester 2013-06-28 20:19:20 UTC
This depends on MediaWiki making the CAPTCHAs available through an API, which I believe is currently not done. Timo to comment.
Comment 3 Krinkle 2013-06-28 22:33:00 UTC
Right now the handling of any error results the following alert:

> Error saving data to server: Failed request: {api.result}.

The only variable we use is the result code, not the error code. And though the error code varies (badtoken, hookabort, needcaptcha) the result is always "error".

Fortunately (at least) the ConfirmEdit extension, and specifically the FancyCaptcha variant (which Wikimedia uses) does provide an API and exposes the following through the EditPage/ApiEdit/ApiVisualEditor result:

{
    "visualeditor": {
        "result": "error",
        "edit": {
            "captcha": {
                "type": "image",
                "mime": "image/png",
                "id": "626590462",
                "url": "//alpha.wikipedia.krinkle.dev/w/index.php?title=Special:Captcha/image&wpCaptchaId=fa4e388ad7"
            },
            "result": "Failure"
        }
    }
}

So it looks like we can use this to build the UI for it.
Comment 4 Gerrit Notification Bot 2013-06-29 20:27:18 UTC
Change 71160 had a related patch set uploaded by Krinkle:
mw: Implement support for ConfirmEdit and FancyCaptcha

https://gerrit.wikimedia.org/r/71160
Comment 5 Gerrit Notification Bot 2013-06-30 03:44:15 UTC
Change 71160 merged by jenkins-bot:
mw: Implement support for ConfirmEdit and FancyCaptcha

https://gerrit.wikimedia.org/r/71160
Comment 6 James Forrester 2013-06-30 08:47:52 UTC
This is now fixed in master and will be deployed on Monday.
Comment 7 Ricordisamoa 2014-03-18 03:05:40 UTC
[[mw:Thread:Extension talk:VisualEditor/VE and ConfirmEdit]]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links