Last modified: 2013-07-22 01:10:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52366, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50366 - Templates that create part (but not all) of a table cell don't work
Templates that create part (but not all) of a table cell don't work
Status: RESOLVED DUPLICATE of bug 44498
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal major
: ---
Assigned To: Gabriel Wicke
:
: 50532 50567 (view as bug list)
Depends on: 50603
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-28 11:08 UTC by Oliver Keyes
Modified: 2013-07-22 01:10 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (37.26 KB, image/png)
2013-06-28 11:08 UTC, Oliver Keyes
Details

Description Oliver Keyes 2013-06-28 11:08:24 UTC
Created attachment 12679 [details]
Screenshot

See screenshot; Windows 7, Firefox 21.0, on https://en.wikipedia.org/wiki/Rage_Against_the_Machine?veaction=edit
Comment 1 James Forrester 2013-07-01 23:20:18 UTC
*** Bug 50532 has been marked as a duplicate of this bug. ***
Comment 2 James Forrester 2013-07-01 23:21:07 UTC
See also https://en.wikipedia.org/wiki/Akon_discography?veaction=edit from bug 50532.
Comment 3 Roan Kattouw 2013-07-01 23:47:34 UTC
Parsoid bug, it doesn't seem to like {{won}} and {{nom}}, see http://parsoid.wmflabs.org/en/Rage_Against_the_Machine
Comment 4 Gabriel Wicke 2013-07-01 23:55:14 UTC
The issue is normally something of this form:

{|
| {{style-and-cell}}
|}

The transclusion returns some attributes and possibly table content.

This cannot easily be parsed in Parsoid while also retaining round-trip information. And even if we could, this would be very hard to represent in HTML so that the VisualEditor can present a sensible user interface for it. So this will remain a limitation of Parsoid.

This issue can however be avoided by changing the template to return the entire table cell including the leading pipe:

{|
{{style-and-cell}}
|}

with {{style-and-cell}} containing:

| style="the style" | The cell content
Comment 5 MZMcBride 2013-07-02 00:56:09 UTC
(In reply to comment #4)
> This cannot easily be parsed in Parsoid while also retaining round-trip
> information. And even if we could, this would be very hard to represent in
> HTML so that the VisualEditor can present a sensible user interface for it. So
> this will remain a limitation of Parsoid.

I'd like to know how many pages are affected by this bug across Wikimedia wikis before it's marked wontfix. Re-opening this for now.
Comment 6 Gabriel Wicke 2013-07-02 02:47:01 UTC
I don't have precise figures right now, but know enough to be sure that a bot will be needed. This bot pass should also fix some other issues listed in http://www.mediawiki.org/wiki/Parsoid/limitations. Do you know a bot author who might be potentially interested in a task like this? We have it on our TODO list, but did not have the time to tackle it before the release.
Comment 7 James Forrester 2013-07-02 16:04:34 UTC
*** Bug 50567 has been marked as a duplicate of this bug. ***
Comment 8 James Forrester 2013-07-02 16:04:49 UTC
*** Bug 50589 has been marked as a duplicate of this bug. ***
Comment 9 kwwilliams 2013-07-02 16:14:51 UTC
50589 has been marked as a duplicate of this bug. I'm certain it's related, but I'm not certain it's a duplicate. *If* it is a duplicate, marking it as "wontfix" isn't an acceptable answer. 

singlechart *does* return the leading | or !, depending on whether it has been ask to generate a row or a header row. It generates two row cells, separated by a |.
Comment 10 Gabriel Wicke 2013-07-02 16:22:24 UTC
Bug 50589 is a different issue, so I reopened it and added detail there.
Comment 11 Gabriel Wicke 2013-07-02 16:50:09 UTC
FYI, we are considering a post-processing work-around in Parsoid that lets this class of templates render as expected, but might not let users edit those templated cells.

Our longer-term goal is to move towards more self-contained templates. This won't happen over night, and we'll need the help of the editor community and bot authors.
Comment 12 Derk-Jan Hartman 2013-07-07 19:46:13 UTC
Similar hack, but now on the table itself, instead of a table cell. See the Infobox of WikiProject Aircraft:

https://en.wikipedia.org/wiki/BAC_One-Eleven
Comment 13 John Mark Vandenberg 2013-07-22 01:10:43 UTC
This bug was raised five months earlier.

*** This bug has been marked as a duplicate of bug 44498 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links