Last modified: 2014-01-11 12:18:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52376, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50376 - change "username" to "email address" in "not valid" error message


Summary:	change "username" to "email address" in "not valid" error message

Status:	PATCH_TO_REVIEW

Product:	Wikimedia
Classification:	Unclassified
Component:	Bugzilla (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Normal minor (vote)
Target Milestone:	---
Assigned To:	Tina Johnson ( tinaj1234 )

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-06-28 13:14 UTC by db [inactive,noenotif]
Modified:	2014-01-11 12:18 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot from FF22 (110.64 KB, image/png) 2013-07-08 10:01 UTC, Andre Klapper	Details
Add an attachment (proposed patch, testcase, etc.)

Description db [inactive,noenotif] 2013-06-28 13:14:33 UTC

You should rephrase the error message

The username or password you entered is not valid.

to "The email address ..."

Maybe there are also some other messages

----
When clicking "Forget Password" there is "Login" and the form looks broken in FF ...

Comment 1 Andre Klapper 2013-07-03 10:21:48 UTC

(In reply to comment #0)
> 
> When clicking "Forget Password" there is "Login" and the form looks broken in
> FF ...

Screenshot highly welcome, plus Firefox version.

Comment 2 db [inactive,noenotif] 2013-07-05 17:54:14 UTC

(In reply to comment #1)
> (In reply to comment #0)
> 
> When clicking "Forget Password" there is
> "Login" and the form looks broken in
> FF ...

Screenshot highly welcome,
> plus Firefox version.

FF 22.0

Comment 3 Andre Klapper 2013-07-08 10:01:10 UTC

Created attachment 12779 [details]
Screenshot from FF22

Confirming the misalignment issue. Quick and dirty fix would be to change the first entry for "margin" for #p-personal #forgot_container .mini_forgot from -5px to -20px, but I still don't understand why there is an issue in the first place.

Comment 4 Tina Johnson ( tinaj1234 ) 2013-10-28 10:55:49 UTC

I am interested in fixing this bug. Please assign this bug to me.

Comment 5 Andre Klapper 2013-10-28 16:22:35 UTC

Note that saying "email address" instead of "login" or "username" is custom code in Wikimedia Bugzilla. The code can be found in 
https://git.wikimedia.org/summary/wikimedia%2Fbugzilla%2Fmodifications.git
See https://www.mediawiki.org/wiki/Developer_access for more information.

Comment 6 Tony Thomas 2013-12-22 14:03:24 UTC

fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=931765

Comment 7 Andre Klapper 2013-12-22 14:37:59 UTC

(In reply to comment #6)
> fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=931765

bugzilla.mozilla.org is not bugzilla.wikimedia.org.

Comment 8 Gerrit Notification Bot 2014-01-11 12:18:47 UTC

Change 106883 had a related patch set uploaded by Tinaj1234:
Error message for invalid login changed.

https://gerrit.wikimedia.org/r/106883

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links