Last modified: 2014-10-06 09:52:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52389, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50389 - Jenkins: Zuul should not run jenkins-bot on changes for refs/meta/*
Jenkins: Zuul should not run jenkins-bot on changes for refs/meta/*
Status: NEW
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Low normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 64678 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-28 19:25 UTC by Krinkle
Modified: 2014-10-06 09:52 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-06-28 19:25:08 UTC

    
Comment 1 Krinkle 2013-06-28 19:25:24 UTC
Causes various false positives and hilarious failures about missing files and what not.
Comment 2 Krinkle 2013-06-28 19:25:31 UTC
https://gerrit.wikimedia.org/r/#/c/71103/
Comment 3 Antoine "hashar" Musso (WMF) 2013-06-28 20:08:44 UTC
Use the web interface ? :-)
Comment 4 Krinkle 2014-03-06 02:17:32 UTC
On changes such https://gerrit.wikimedia.org/r/#/c/117146/ we always get a down vote because Jenkins tries to build it.
Comment 5 Krinkle 2014-03-06 02:21:35 UTC
(In reply to Antoine "hashar" Musso from comment #3)
> Use the web interface ? :-)

That is not an option because for change I'm making most often (disabling Verified/Submit for regular users) doesn't work in the the web interface.

The web interface of Gerrit is broken. It requires all values to be autocompleted, and one due to a bug in Gerrit you can only autocomplete group names you're an admin of (so only Gerrit root admins can make changes that introduce group names). 

Through the commit interface it works fine however, and there is no security reason to restrict it either, it's purely a bug in the UI.

Either way, there are other branches as well. Zuul should only run on repository code related branches. These meta branches, unless we plan to write jobs for them (at which point we should have to explicitly whitelist them), there is no point in letting Zuul run over it.
Comment 6 Antoine "hashar" Musso (WMF) 2014-03-06 14:31:01 UTC
I was merely minding Timo sorry ;-D

You can potentially add a ref filter on each of the Zuul pipeline. Something like:

 - name: test
   trigger:
     gerrit:
      - event: patchset-created
        ref: ^(?!refs/meta/config).*$

That should discard patches on refs/meta/config
Comment 7 Krinkle 2014-10-06 09:52:16 UTC
*** Bug 64678 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links