Last modified: 2014-02-28 23:51:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52405, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50405 - VisualEditor: Come up with a solution of section edit links' placement when they are floated right (due to a gadget)
VisualEditor: Come up with a solution of section edit links' placement when t...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Lowest enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-28 23:08 UTC by Eduard Braun
Modified: 2014-02-28 23:51 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Trivial patch idea (590 bytes, text/html)
2013-06-30 19:52 UTC, Eduard Braun
Details

Description Eduard Braun 2013-06-28 23:08:08 UTC
Until a recent MediaWiki change the default behavior of edit section links was to float to the far side of the heading (right on LTR Wikis, assume this case in the following).

This was changed recently but almost all Wikis provide Gadgets to restore the old behavior (see http://en.wikipedia.org/wiki/MediaWiki:Gadget-righteditlinks.css or http://de.wikipedia.org/wiki/MediaWiki:Gadget-editsection-align-end.css for examples)

The problem is, that the VisualEditor's fly-out-links reserve space to the right for the "edit source" link. Therefore when aligning the links right they actually appear with a large distance to the page-margin. The fly-outs should therefore be modified to not reserve any space so the "edit" link is correctly aligned right.

To prevent the fly-outs to shift the whole "edit" link left as soon as they become visible they could be changed to fly-out to the left in this case or to the bottom.
Comment 1 James Forrester 2013-06-30 19:20:13 UTC
(In reply to comment #0)
> Until a recent MediaWiki change the default behavior of edit section links
> was
> to float to the far side of the heading (right on LTR Wikis, assume this case
> in the following).
> 
> This was changed recently but almost all Wikis provide Gadgets to restore the
> old behavior (see
> http://en.wikipedia.org/wiki/MediaWiki:Gadget-righteditlinks.css or
> http://de.wikipedia.org/wiki/MediaWiki:Gadget-editsection-align-end.css for
> examples)
> 
> The problem is, that the VisualEditor's fly-out-links reserve space to the
> right for the "edit source" link. Therefore when aligning the links right
> they
> actually appear with a large distance to the page-margin. The fly-outs should
> therefore be modified to not reserve any space so the "edit" link is
> correctly
> aligned right.
> 
> To prevent the fly-outs to shift the whole "edit" link left as soon as they
> become visible they could be changed to fly-out to the left in this case or
> to the bottom.

Note that in general WMF does not support gadgets and does not encourage their use; they are highly likely to break like this when the code they depend on changes, and this is a good example of that breakage. :-(

I've re-written this a bit to be clearer. As "lowest" priority, reflecting that we don't support gadgets. of course anyone who is interested in patching is welcome to suggest ideas/code that could address this.
Comment 2 Eduard Braun 2013-06-30 19:26:43 UTC
I see your point but you have to admit that without changing the style of the edisection-links these Gadgets wouldn't have been necessary in the first place. They are basically "fixing" what WMF "broke" so it would be nice if you at least tried to supply a solution.
Comment 3 Eduard Braun 2013-06-30 19:52:40 UTC
Created attachment 12706 [details]
Trivial patch idea

To add some content: Wouldn't a trivial patch along the lines of the attachment be sufficient to fix this problem?

I'm sure something like this could be implemented with minimal effort for somebody with a little experience!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links