Last modified: 2013-07-15 01:46:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52423, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50423 - VisualEditor: ref warning appears within template that contains references, post-modification
VisualEditor: ref warning appears within template that contains references, p...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Highest minor
: VE-deploy-2013-07-11
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-29 14:22 UTC by Oliver Keyes
Modified: 2013-07-15 01:46 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (109.99 KB, image/png)
2013-06-29 14:22 UTC, Oliver Keyes
Details

Description Oliver Keyes 2013-06-29 14:22:39 UTC
Created attachment 12685 [details]
Screenshot

See the screenshot; I imagine the reference is being treated as existing within the template, rather than within the template within the page - it hunts for <references\>, can't find a tag in the template itself, and freaks the heck out.
Comment 1 James Forrester 2013-07-01 14:56:57 UTC
The short-term fix is to just strip this comment from the returned HTML that the PHP parser gives us.

When we switch over to using Parsoid for this, we'll need that to run in context, somehow, so the references are correctly numbered and that we know to update the relevant reference lists.
Comment 2 Gerrit Notification Bot 2013-07-10 21:36:18 UTC
Change 73092 had a related patch set uploaded by Esanders:
Hide ref errors inside MW transclusions

https://gerrit.wikimedia.org/r/73092
Comment 3 Gerrit Notification Bot 2013-07-10 23:05:12 UTC
Change 73092 merged by jenkins-bot:
Hide ref errors inside MW transclusions

https://gerrit.wikimedia.org/r/73092
Comment 4 James Forrester 2013-07-10 23:13:03 UTC
These are now hidden by the above commit, which we're deploying in the next few minutes.
Comment 5 Ed Sanders 2013-07-11 11:43:49 UTC
Also: https://gerrit.wikimedia.org/r/73096
Comment 6 Ed Sanders 2013-07-11 11:44:16 UTC
Should probably leave this open to track improvements.
Comment 7 Gerrit Notification Bot 2013-07-14 14:41:27 UTC
Change 73614 had a related patch set uploaded by Esanders:
Use new class to detect Cite errors inside templates

https://gerrit.wikimedia.org/r/73614
Comment 8 James Forrester 2013-07-15 01:46:25 UTC
I'm forking this off into bug 51337.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links