Last modified: 2013-07-15 19:46:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52424, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50424 - VisualEditor: "Invalid token" message after period of inactivity leads to lost work
VisualEditor: "Invalid token" message after period of inactivity leads to los...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Highest major
: VE-deploy-2013-07-18
Assigned To: Krinkle
:
: 51302 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-29 15:47 UTC by Axel Boldt
Modified: 2013-07-15 19:46 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Axel Boldt 2013-06-29 15:47:20 UTC
An attempt to save an article in the visual editor after a period of inactivity results in the "Invalid token" error message and saving fails. At this point, the user is completely stuck and their entire work is lost. 

Loss of session data can also occur in the regular source code edit window, but is easily rectified by repeated saving; this doesn't work in the visual editor. 

I would classify this as user-hostile behavior.
Comment 1 Gerrit Notification Bot 2013-07-11 18:11:18 UTC
Change 73189 had a related patch set uploaded by Krinkle:
API: Split save action into separate API module

https://gerrit.wikimedia.org/r/73189
Comment 2 Gerrit Notification Bot 2013-07-11 18:11:21 UTC
Change 73203 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget: Improve error message for badtoken error

https://gerrit.wikimedia.org/r/73203
Comment 3 Gerrit Notification Bot 2013-07-11 23:11:24 UTC
Change 73189 merged by jenkins-bot:
api: Split save action into separate API module

https://gerrit.wikimedia.org/r/73189
Comment 4 Gerrit Notification Bot 2013-07-11 23:22:17 UTC
Change 73203 merged by jenkins-bot:
mw.ViewPageTarget: Improve error message for badtoken error

https://gerrit.wikimedia.org/r/73203
Comment 5 Gerrit Notification Bot 2013-07-12 18:27:58 UTC
Change 73446 had a related patch set uploaded by Krinkle:
(DRAFT) mw.ViewPageTarget: Refetch token if session expired

https://gerrit.wikimedia.org/r/73446
Comment 6 James Forrester 2013-07-13 23:57:24 UTC
*** Bug 51302 has been marked as a duplicate of this bug. ***
Comment 7 John Mark Vandenberg 2013-07-14 03:05:35 UTC
I just encountered this problem.  I would call this bug a blocker as it is effectively 'dataloss' in bmo keyword terminology!
Comment 8 Axel Boldt 2013-07-14 05:38:19 UTC
Please note that the reporter of Bug 51302 also points out that the session expiry clock already starts ticking once an article is opened for *reading*, i.e. potentially much earlier than when the visual editor is started on the article.
Comment 9 Gerrit Notification Bot 2013-07-15 19:44:39 UTC
Change 73446 merged by jenkins-bot:
mw.ViewPageTarget: Refetch token if session expired

https://gerrit.wikimedia.org/r/73446
Comment 10 James Forrester 2013-07-15 19:46:13 UTC
This is now fixed in master, which will be deployed within the hour.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links