Last modified: 2013-07-03 10:51:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52430, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50430 - Undefined Offsets in OpenIDLogin for Strict PHP
Undefined Offsets in OpenIDLogin for Strict PHP
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OpenID (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: T. Gries
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-29 19:00 UTC by Jack D. Pond
Modified: 2013-07-03 10:51 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Fixed file - ready for commit to REL1_21 (27.36 KB, application/x-httpd-php)
2013-06-29 19:00 UTC, Jack D. Pond
Details
Patch file for REL1_21 (3.72 KB, patch)
2013-06-29 19:23 UTC, Jack D. Pond
Details

Description Jack D. Pond 2013-06-29 19:00:47 UTC
Created attachment 12686 [details]
Fixed file - ready for commit to REL1_21

When logging into OpenID (At least with myopenid),

Notice: Undefined offset: 0 in extensions/OpenID/SpecialOpenIDLogin.body.php on line 524
Notice: Undefined offset: 0 in extensions/OpenID/SpecialOpenIDLogin.body.php on line 556
Notice: Undefined offset: 0 in extensions/OpenID/SpecialOpenIDLogin.body.php on line 556

This is caused by using a non-existent array key and shows up as an error.

I haven't checked the current head, but the attached patch fixes REL1_21

(Two files, one patch, one fixed REL1_21)
Comment 1 Jack D. Pond 2013-06-29 19:23:05 UTC
Created attachment 12687 [details]
Patch file for REL1_21

Patch file to correct index bug in REL1_21
Comment 2 Andre Klapper 2013-06-29 19:49:59 UTC
Hi Jack! Thanks for your patch!

You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly.
Thanks again! We appreciate your contribution.
Comment 3 Gerrit Notification Bot 2013-06-30 01:46:30 UTC
Change 71256 had a related patch set uploaded by Jpond:
(bug 50430) Generates null array errors in strict php mode for fullname and email

https://gerrit.wikimedia.org/r/71256
Comment 4 Gerrit Notification Bot 2013-06-30 02:45:49 UTC
Change 71258 had a related patch set uploaded by Jpond:
(bug 50430) Generates null array errors strict php mode for fullname and email

https://gerrit.wikimedia.org/r/71258
Comment 5 Gerrit Notification Bot 2013-06-30 05:29:18 UTC
Change 71256 had a related patch set uploaded by Parent5446:
(bug 50430) Generates null array errors in strict php mode for fullname and email

https://gerrit.wikimedia.org/r/71256
Comment 6 Gerrit Notification Bot 2013-06-30 05:33:50 UTC
Change 71256 abandoned by Parent5446:
Generates null array errors in strict php mode for fullname and email

Reason:
This is the same as https://gerrit.wikimedia.org/r/71258. I'm guessing there was some error when uploading the patchset.

https://gerrit.wikimedia.org/r/71256
Comment 7 Gerrit Notification Bot 2013-06-30 05:34:21 UTC
Change 71258 had a related patch set uploaded by Parent5446:
(bug 50430) Generates null array errors strict php mode for fullname and email

https://gerrit.wikimedia.org/r/71258
Comment 8 Gerrit Notification Bot 2013-07-03 06:18:44 UTC
Change 71258 merged by Wikinaut:
fixed null array error for fullname/email in AX array

https://gerrit.wikimedia.org/r/71258
Comment 9 T. Gries 2013-07-03 06:23:44 UTC
fixed by merging https://gerrit.wikimedia.org/r/71258

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links