Last modified: 2013-07-04 10:34:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52447, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50447 - Parsoid: One missing apostrophe causes corruption across table cells
Parsoid: One missing apostrophe causes corruption across table cells
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-30 06:20 UTC by Roan Kattouw
Modified: 2013-07-04 10:34 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2013-06-30 06:20:54 UTC
Minimal test case:

{|
|-
| align=left colspan=3|'''Valid Votes'''||'''38,847''||'''100.00%'''
|}


Note that the bolding of 38,847 is not closed correctly: one quote is missing.

The PHP parser renders this (correctly) as:
<td><b>Valid Votes</b></td><td>'<i>Valid Votes</i></td><td><b>100.00%</b></td>

Parsoid renders this in an ... interesting way:
<td>'<i>Valid Votes<b></b></i></td>38,847</td><td><b>100.00%</b></td>

Note the stray quote before Valid Votes, the fact that Valid Votes is now in italic, the empty <b> tag, and the fact that 38,847 is completely unformatted.

Because the output HTML is so weird, this obviously doesn't round-trip right either:

| align="left" colspan="3" |'''Valid Votes''''''''||38,847||'''100.00%'''

The real-world test case that brought this to my attention is http://parsoid.wmflabs.org/_rt/en/Wellawatte-Galkissa_Electoral_District?oldid=377319087
Comment 1 Gerrit Notification Bot 2013-07-01 03:07:34 UTC
Change 71312 had a related patch set uploaded by Subramanya Sastry:
(Bug 50447) Quote balancing should not cross td/th boundaries

https://gerrit.wikimedia.org/r/71312
Comment 2 Gerrit Notification Bot 2013-07-01 15:42:40 UTC
Change 71312 merged by jenkins-bot:
(Bug 50447) Quote balancing should not cross td/th boundaries

https://gerrit.wikimedia.org/r/71312
Comment 3 Andre Klapper 2013-07-04 10:34:21 UTC
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links