Last modified: 2013-07-15 23:29:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52461, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50461 - VisualEditor: Clear annotations icon no longer clearing link annotations
VisualEditor: Clear annotations icon no longer clearing link annotations
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-07-18
Assigned To: Ed Sanders
:
: 51018 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-30 14:02 UTC by Guillaume Paumier
Modified: 2013-07-15 23:29 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Guillaume Paumier 2013-06-30 14:02:33 UTC
The formatting icons of the VisualEditor toolbar are currently "B" for bold, "I" for italics, the chain for links and the remove icon to clear formatting.

This series of icon seems to indicate that links are a kind of formatting. However; "Clear formatting" doesn't affect links; it only removes bold and italics.

Either links *are* a kind of formatting, and the "Clear formatting" action should remove them, or they aren't, and the Link icon shouldn't stand in the middle of icons that add and clear formatting. The current order and behavior are confusing.
Comment 1 James Forrester 2013-06-30 17:03:42 UTC
This is a regression; it used to work fine - relabelling as such.
Comment 2 James Forrester 2013-07-11 01:01:25 UTC
*** Bug 51018 has been marked as a duplicate of this bug. ***
Comment 3 Gerrit Notification Bot 2013-07-15 23:07:12 UTC
Change 73896 had a related patch set uploaded by Esanders:
Compare annotations by name only when clearing/toggling

https://gerrit.wikimedia.org/r/73896
Comment 4 Gerrit Notification Bot 2013-07-15 23:22:57 UTC
Change 73896 merged by jenkins-bot:
Compare annotations by name only when clearing/toggling

https://gerrit.wikimedia.org/r/73896
Comment 5 James Forrester 2013-07-15 23:29:26 UTC
Fixed and will go out in a few minutes.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links