Last modified: 2014-03-13 16:54:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52475, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50475 - VisualEditor: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504)
VisualEditor: More gracefully handle situations where Parsoid returns a timeo...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Initialisation (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2014-03-13
Assigned To: Alex Monk
:
Depends on: 51053
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-30 19:36 UTC by Carl Fürstenberg
Modified: 2014-03-13 16:54 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Carl Fürstenberg 2013-06-30 19:36:31 UTC
Trying to "Edit" on http://en.wikipedia.org/wiki/List_of_Advanced_Dungeons_%26_Dragons_2nd_edition_monsters after a minute or so results in a popup "Error loading data from server: error. Would you like to retry?". Trying again, repeats the issue
Comment 1 Maggie Dennis 2013-07-01 13:18:18 UTC
I think this is probably related - editing on large pages such as California is considerably slower when using VE than it is using the old editor. A contributor complained of slowness with this edit (http://en.wikipedia.org/w/index.php?title=California&diff=562339624&oldid=562339237) and I found the same issue with mine (http://en.wikipedia.org/w/index.php?title=California&diff=562390635&oldid=562351322)
Comment 2 Erik Moeller 2013-07-06 18:05:53 UTC
Re: timeouts, need to be either handled more gracefully or we'll need to VE-blacklist articles where it occurs for now.
Comment 3 Erik Moeller 2013-07-09 01:56:39 UTC
Looks like the timeout here is on the Varnish/Parsoid side (API request on edit fails with error 504 after 60 secs).
Comment 4 James Forrester 2013-07-09 02:05:25 UTC
Possibily we could, instead of giving the user the error code, we could have a pop-up saying "It looks like editor is currently unavailable; would you like to edit in source mode instead?" with an OK that takes you to action=edit and a cancel that returns you to action=view? Maybe for error-tracking purposes we could add <small>Parsoid returned 504</small> or <small>Parsoid not available</small> after the general call-to-action?
Comment 5 Gabriel Wicke 2013-07-10 18:33:31 UTC
After upping the Varnish backend timeout to 5 minutes http://en.wikipedia.org/wiki/List_of_Advanced_Dungeons_%26_Dragons_2nd_edition_monsters?veaction=edit works now despite timing out in VE once. Hitting 'retry' re-joins the ongoing render, and returns the page pretty quickly. Previewing that page also works in about 30 seconds.

You might want to tweak your timeouts / UI to reflect this change. As long as there is no timout from Varnish the render is still ongoing.

More testing is needed with even larger pages. Bug 51053 will be closed when that is done.
Comment 6 Gabriel Wicke 2013-07-10 18:36:52 UTC
(In reply to comment #5)
> Previewing that page also works in about 30 seconds.

Actually closer to 70 on re-test.
Comment 7 Roan Kattouw 2013-07-10 18:50:19 UTC
VE currently sets a 100s timeout, but in practice we often don't get there because the nginx proxies that terminate HTTPS and IPv6 traffic have a 60s timeout.
Comment 8 James Forrester 2013-07-11 00:23:13 UTC
I'm pulling this from being a blocker to bug 50848, given the reduced impact now that it works on the second try.
Comment 9 Alex Monk 2014-02-08 17:07:57 UTC
(resetting assignee - I had issues trying to properly reproduce Parsoid timeouts like this on my machine)
Comment 10 James Forrester 2014-02-09 02:41:58 UTC
We'll help. :-)
Comment 11 Alex Monk 2014-03-12 23:38:50 UTC
(In reply to James Forrester from comment #4)
> Possibily we could, instead of giving the user the error code, we could have
> a pop-up saying "It looks like editor is currently unavailable; would you
> like to edit in source mode instead?" with an OK that takes you to
> action=edit and a cancel that returns you to action=view? Maybe for
> error-tracking purposes we could add <small>Parsoid returned 504</small> or
> <small>Parsoid not available</small> after the general call-to-action?

Basically done this after checking with Roan about how to reproduce this error, without the small text underneath. Confirm dialogs don't allow you to use HTML markup.
Comment 12 Gerrit Notification Bot 2014-03-12 23:41:24 UTC
Change 118398 had a related patch set uploaded by Alex Monk:
More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504)

https://gerrit.wikimedia.org/r/118398
Comment 13 Gerrit Notification Bot 2014-03-13 00:54:32 UTC
Change 118398 merged by jenkins-bot:
More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504)

https://gerrit.wikimedia.org/r/118398

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links