Last modified: 2013-07-01 20:16:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52483, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50483 - VisualEditor: Likely invalid HTML emitted for list items
VisualEditor: Likely invalid HTML emitted for list items
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: High major
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-01 01:20 UTC by Quiddity
Modified: 2013-07-01 20:16 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of list indent problem (31.23 KB, image/png)
2013-07-01 01:20 UTC, Quiddity
Details

Description Quiddity 2013-07-01 01:20:12 UTC
Created attachment 12708 [details]
Screenshot of list indent problem

If I add indent to any list item, it breaks. 

The indented line gets moved to the end of the previous line.

The live-changes looks as it is working properly, but the edit-diff (preview your changes) always shows it as broken. (See attachment)

Confirmed with:
* Firefox and Chrome,
* with ordered and un-ordered list items, 
* with items added to the middle of a list, and to the end of a list,
* and with both new items added to a list, and existing items given increased indent.
Comment 1 James Forrester 2013-07-01 15:15:14 UTC
This appears to be a (new?) bug in Parsoid - 

# Foo
# Bar

-> 

# Foo## Bar

rather than

# Foo
## Bar

Unless we're breaking something in VisualEditor somehow?
Comment 2 Gabriel Wicke 2013-07-01 15:55:00 UTC
Cannot reproduce:

echo -e '#foo\n#bar' | node parse --wt2wt
#foo
#bar

Can you provide the HTML the VE sends?
Comment 3 Gabriel Wicke 2013-07-01 16:02:34 UTC
Also:
echo '<ol><li>foo</li><li>bar</li></ol>' | node parse --html2wt
#foo
#bar
Comment 4 Gabriel Wicke 2013-07-01 18:26:28 UTC
I'm guessing that VE emits the wrong HTML here, so reassigning to VE. Please move to Parsoid again if the VE HTML is sane.
Comment 5 Roan Kattouw 2013-07-01 18:40:23 UTC
$ echo '<ol><li>Foo<ol><li>Bar</li></ol></li></ol>' | node js/tests/parse.js  --html2wt 
#Foo##Bar
Comment 6 ssastry 2013-07-01 18:46:16 UTC
Looks like Parsoid serializer is newline sensitive in this case:

$ echo '<ol><li>Foo\n<ol><li>Bar</li></ol></li></ol>' | node parse.js --html2wt
#Foo
##Bar
Comment 7 ssastry 2013-07-01 18:48:56 UTC
This is not a new bug.  This has been around for a long time.  I went back to commits almost 3 months back and tested.
Comment 8 Gerrit Notification Bot 2013-07-01 19:25:51 UTC
Change 71395 had a related patch set uploaded by GWicke:
Bug 50483: Make sure nested list serialization is newline-insensitive

https://gerrit.wikimedia.org/r/71395
Comment 9 Gerrit Notification Bot 2013-07-01 19:53:30 UTC
Change 71395 merged by jenkins-bot:
Bug 50483: Make sure nested list serialization is newline-insensitive

https://gerrit.wikimedia.org/r/71395

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links