Last modified: 2014-01-08 16:47:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52488, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50488 - #REDIRECT [[A]] [[File:Filename.jpg]] incorrectly registers the redirect page as a file redirect to File:Filename.jpg in "File usage" section on [[File:Filename.jpg]]
#REDIRECT [[A]] [[File:Filename.jpg]] incorrectly registers the redirect page...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Redirects (Other open bugs)
1.22.0
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-01 07:28 UTC by Liangent
Modified: 2014-01-08 16:47 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Umherirrender 2013-09-21 17:20:12 UTC
Cannot reproduce on local wiki, can you fix your test case (choose another image or so)?
Comment 2 Bawolff (Brian Wolff) 2013-09-21 17:24:29 UTC
Still present - https://test2.wikipedia.org/wiki/File:Title_0.40766062783257595.png and https://test2.wikipedia.org/w/index.php?title=User:Bawolff/bug50488&redirect=no

The file redirect code seems to makes some bad assumptions that nothing else will be on redirect page (See for example the bug about categories not showing up on file redirect pages).
Comment 3 Umherirrender 2013-09-21 18:28:51 UTC
I assume that Liangent where redirect to the file page, when visit the page (or the file page is stored in the redirect table), but that is wrong, the redirect will you show the content of the first page. Auto summary also shows, that the correct redirect was extracted

It is more a feature, than a bug, that other content of a redirect page gets parsed and the tables gets it content. Wikipedia adds categories or person data to redirects. That extra content is not shown is another bug.
Comment 4 Bawolff (Brian Wolff) 2013-09-21 18:36:53 UTC
(In reply to comment #3)

> 
> It is more a feature, than a bug, that other content of a redirect page gets
> parsed and the tables gets it content.

Yes, the bug is that when showing what pages the file is used in, it assumes that any page listed in the imagelinks table that is also a redirect must be a redirect to the current file.
Comment 5 Liangent 2013-09-21 20:15:45 UTC
(In reply to comment #4)
> (In reply to comment #3)
> 
> > 
> > It is more a feature, than a bug, that other content of a redirect page gets
> > parsed and the tables gets it content.
> 
> Yes, the bug is that when showing what pages the file is used in, it assumes
> that any page listed in the imagelinks table that is also a redirect must be
> a
> redirect to the current file.

Updated summary to clarify the appearance.
Comment 6 Umherirrender 2013-09-22 05:52:33 UTC
ImagePage is using the page_is_redirect field of the page table to determine, if the page is a redirect, but when a file is used on a redirect, that is ambiguous, has to use the redirect table instead.
Comment 7 Gerrit Notification Bot 2013-09-22 07:53:54 UTC
Change 85517 had a related patch set uploaded by Umherirrender:
Fix redirect detection on image page's "file usages" section

https://gerrit.wikimedia.org/r/85517
Comment 8 Gerrit Notification Bot 2013-12-19 10:16:52 UTC
Change 85517 abandoned by Umherirrender:
Fix redirect detection on image page's "file usages" section

Reason:
Still no idea how to avoid a filesort here (see inline comment)

https://gerrit.wikimedia.org/r/85517
Comment 9 Umherirrender 2013-12-19 10:18:04 UTC
Remove assigned
Comment 10 Gerrit Notification Bot 2014-01-06 21:30:52 UTC
Change 105829 had a related patch set uploaded by Anomie:
Move redirect rendering into WikitextContent

https://gerrit.wikimedia.org/r/105829
Comment 11 Gerrit Notification Bot 2014-01-07 22:45:11 UTC
Change 105829 merged by jenkins-bot:
Move redirect rendering into WikitextContent

https://gerrit.wikimedia.org/r/105829
Comment 12 Brad Jorsch 2014-01-08 16:47:24 UTC
Should be deployed to WMF wikis with 1.23wmf10, see https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links