Last modified: 2013-07-02 01:10:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52534, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50534 - VisualEditor: Firefox 10 and under have issues and should be blacklisted
VisualEditor: Firefox 10 and under have issues and should be blacklisted
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-07-04
Assigned To: James Forrester
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-01 22:51 UTC by Oliver Keyes
Modified: 2013-07-02 01:10 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-07-01 22:51:52 UTC
A firefox 5.0 user is reporting that blacklisting simply isn't working - they're seeing the VE, broken. Their response to "are you spoofing user headers" was along the lines of "what the heck is that?" which answers that question.
Comment 1 James Forrester 2013-07-01 22:55:36 UTC
We don't blacklist Firefox 5. We currently blacklist:

* MSIE <= 10
* Android <= 3
* Blackberry
* Opera

We whitelist:
* Firefox >= 11
* Iceweasel >= 10
* Safari >= 5
* Chrome >= 19

All other browsers are let through, with a warning.

Does this mean we should blacklist Firefox 5.0?
Comment 2 Oliver Keyes 2013-07-01 22:57:39 UTC
Wait, so non-whitelisted browsers are let through? Is this documented anywhere?

I'd suggest anything not whitelisted be blacklisted, frankly. We've got firefoxes 5, 9 and 10 producing substantial problems.
Comment 3 Chris McMahon 2013-07-01 23:00:56 UTC
Tried FF 5, 9, and 10, VE "Edit" links are available in all of them along with "Edit source" links.  In each case VE only displays the loading bars and does not present any usable interface.
Comment 4 James Forrester 2013-07-01 23:25:01 UTC
(In reply to comment #3)
> Tried FF 5, 9, and 10, VE "Edit" links are available in all of them along
> with
> "Edit source" links.  In each case VE only displays the loading bars and does
> not present any usable interface.

We've had a user swear blind that everything works fine in FF 10. Clearly they misled us. :-(
Comment 5 Gerrit Notification Bot 2013-07-01 23:27:24 UTC
Change 71554 had a related patch set uploaded by Jforrester:
Blacklist Firefox <= 10 per reports that it's broken

https://gerrit.wikimedia.org/r/71554
Comment 6 Chris McMahon 2013-07-01 23:28:53 UTC
I re-checked FF10 on Windows 7:  whether editing a whole page or a section of a page FF10 presents the loading... bars but never presents the editor
Comment 7 James Forrester 2013-07-01 23:31:18 UTC
(In reply to comment #6)
> I re-checked FF10 on Windows 7:  whether editing a whole page or a section
> of a page FF10 presents the loading... bars but never presents the editor

OK, we'll blacklist Firefox 10 and under per the above patch; will see if we can do a quick deploy today to avoid user confusion.
Comment 8 Gerrit Notification Bot 2013-07-01 23:59:25 UTC
Change 71554 merged by jenkins-bot:
Blacklist Firefox <= 10 per reports that it's broken

https://gerrit.wikimedia.org/r/71554
Comment 9 James Forrester 2013-07-02 01:10:23 UTC
This is now deployed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links