Last modified: 2013-11-27 13:44:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52562, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50562 - Canceling font change doesn't work for system font
Canceling font change doesn't work for system font
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Santhosh Thottingal
:
: 50563 52571 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-02 08:46 UTC by Niklas Laxström
Modified: 2013-11-27 13:44 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2013-07-02 08:46:26 UTC 
1) Go to http://en.wikipedia.org/wiki/Main_Page
2) Click Cog
3) Click [Fonts]
4) Choose Open Dyslexic for English
5) Click [Apply]
6) Click Cog
7) Choose system for English
8) Click [Cancel]

Observed: System is stays as the chosen font
Observed: Open Dyslexic is back when page is refreshed
Expected: Reverted back to Open Dyslexic immediately when clicking cancel
Comment 1 Nemo 2013-07-02 08:55:11 UTC 
*** Bug 50563 has been marked as a duplicate of this bug. ***
Comment 2 Santhosh Thottingal 2013-07-19 05:10:18 UTC 
This happens only when system(pageload)->fontA(apply)->system(cancel) UX sequence.

Works as expected in fontA(pageload)->system(cancel) cases.

Reason for bug:

The "previous font" value is set on page load and does not get updated on next font changes. So cancel is pressed, this "previous font" is applied.
Comment 3 Gerrit Notification Bot 2013-07-19 05:11:53 UTC 
Change 74583 had a related patch set uploaded by Santhosh:
Update the previous UI and content font whenever font value changes

https://gerrit.wikimedia.org/r/74583
Comment 4 Gerrit Notification Bot 2013-07-21 16:20:32 UTC 
Change 74583 merged by jenkins-bot:
Update the previous UI and content font whenever font value changes

https://gerrit.wikimedia.org/r/74583
Comment 5 Siebrand Mazeland 2013-08-06 05:23:45 UTC 
*** Bug 52571 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links