Last modified: 2014-02-12 23:53:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52571, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50571 - {{PLURAL}} not working in 'mobile-frontend-diffview-editcount' message
{{PLURAL}} not working in 'mobile-frontend-diffview-editcount' message
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-02 10:57 UTC by Ltrlg
Modified: 2014-02-12 23:53 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ltrlg 2013-07-02 10:57:58 UTC
The message 'mobile-frontend-diffview-editcount' contains a {{PLURAL:$1}}, but $1 is something like '<div>19,247</div>', so {{PLURAL}} returns always singular (see https://fr.m.wikipedia.org/wiki/Special:MobileDiff/94625388 for example).

Please add a second parameter which is the only number, non-formated.
Comment 1 Gerrit Notification Bot 2013-07-02 16:04:03 UTC
Change 71630 had a related patch set uploaded by Jdlrobson:
Bug 50571: Make plural work for mobile-frontend-diffview-editcount

https://gerrit.wikimedia.org/r/71630
Comment 2 Gerrit Notification Bot 2013-07-02 16:10:57 UTC
Change 71630 merged by jenkins-bot:
Bug 50571: Make plural work for mobile-frontend-diffview-editcount

https://gerrit.wikimedia.org/r/71630
Comment 3 Ltrlg 2013-07-02 17:23:53 UTC
As I can see in this patch, the number is still formated.

But {{PLURAL:1,000|sg|pl}} returns 'sg', so 'mobile-frontend-diffview-editcount' will still be incorrectly displayed.

This is the reason why I suggested to add a second parameter
Comment 4 Ltrlg 2013-07-02 17:28:27 UTC
Sorry, I verified : {{PLURAL:1,000|sg|pl}} returns 'pl' on an English wiki, I was testing on a French one.
Comment 5 Jon 2013-07-02 19:22:34 UTC
*Confused* do I need to add a second parameter?
I tried to use one but it seemed to have no effect.
For me plural works with this patchset - but I've only tested on English - are you saying it doesn't?
Comment 6 Ltrlg 2013-07-02 22:37:23 UTC
It’s working, the tests I did was incorrect.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links