Last modified: 2013-07-08 08:07:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52575, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50575 - Languages cogwheel missing accessibility features
Languages cogwheel missing accessibility features
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
master
All All
: Normal enhancement (vote)
: ---
Assigned To: Santhosh Thottingal
: accessibility
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-02 11:50 UTC by Derk-Jan Hartman
Modified: 2013-07-08 08:07 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2013-07-02 11:50:26 UTC 
span + click handler does not make an accessible feature.

Please add: attr('tabIndex', 0).attr('role', 'button')
Comment 1 Niklas Laxström 2013-07-02 12:13:43 UTC 
role=button makes sense but I don't understand why we would want to set tabIndex for it.
Comment 2 Derk-Jan Hartman 2013-07-02 17:15:34 UTC 
tabIndex marks an element as focusable in the accessibility dom (which a span or div by default isn't). Alternatively, you can also just use an actual button of course.

https://developer.mozilla.org/en-US/docs/Accessibility/Keyboard-navigable_JavaScript_widgets
Comment 3 Gerrit Notification Bot 2013-07-03 12:01:01 UTC 
Change 71784 had a related patch set uploaded by Santhosh:
Accessibility attributes for ULS trigger

https://gerrit.wikimedia.org/r/71784
Comment 4 Gerrit Notification Bot 2013-07-04 17:32:27 UTC 
Change 71998 had a related patch set uploaded by Vogone:
Fixed import source for testwikidatawiki

https://gerrit.wikimedia.org/r/71998
Comment 5 Vogone 2013-07-07 19:16:33 UTC 
(In reply to comment #4)
> Change 71998 had a related patch set uploaded by Vogone:
> Fixed import source for testwikidatawiki
> 
> https://gerrit.wikimedia.org/r/71998

I'm sorry. This one is unrelated to this bug.
Comment 6 Gerrit Notification Bot 2013-07-08 07:42:01 UTC 
Change 71784 merged by jenkins-bot:
Accessibility attributes for ULS trigger

https://gerrit.wikimedia.org/r/71784
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links