Last modified: 2013-08-22 14:36:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52588, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50588 - API claim functions should be POST only and require write rights
API claim functions should be POST only and require write rights
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized major (vote)
: ---
Assigned To: Addshore
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-02 15:45 UTC by Addshore
Modified: 2013-08-22 14:36 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Addshore 2013-07-02 15:45:54 UTC 
As with all other API functions that edit/create/delete data in one way or another the claim functions should be POST only.

The below can currently be used without POSTing and without write rights

* wbcreateclaim
* wbremoveclaims
* wbsetclaimvalue
* wbsetclaim
Comment 1 Gerrit Notification Bot 2013-07-03 10:07:20 UTC 
Change 71773 had a related patch set uploaded by Addshore:
Adding permissions for claims in wikidata api

https://gerrit.wikimedia.org/r/71773
Comment 2 Gerrit Notification Bot 2013-07-07 07:17:39 UTC 
Change 71773 abandoned by Addshore:
Adding permissions for claims in wikidata api

Reason:
I think this is going to have to be split up into stages along with a total rework of parts of the api.
I have submitted some of these for review already that would break this change further.

https://gerrit.wikimedia.org/r/71773
Comment 3 Addshore 2013-07-10 13:48:55 UTC 
POST only has been fixed with https://gerrit.wikimedia.org/r/72528
Comment 4 Addshore 2013-08-13 10:48:31 UTC 
All relevant changes that are going to happen here have happened with the recent modification of all of the claim modules when making them use changeops.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links