Last modified: 2013-07-11 16:49:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52604, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50604 - Domino does not handle additive formatting elements correctly
Domino does not handle additive formatting elements correctly
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: C. Scott Ananian
:
Depends on:
Blocks: 49755
  Show dependency treegraph
 
Reported: 2013-07-02 19:52 UTC by Ed Sanders
Modified: 2013-07-11 16:49 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2013-07-02 19:52:28 UTC
<big>Foo<big>Bar</big>Baz</big> (html)

serialises to:

<big>Foo<big>Bar</big></big>Baz (wikitext)
Comment 1 Gabriel Wicke 2013-07-02 19:57:39 UTC
This seems to be a domino bug:

domino.createDocument('<big>Foo<big>Bar</big>Baz</big>').outerHTML;
'<html><head></head><body><big>Foo<big>Bar</big></big>Baz</body></html>'
Comment 2 ssastry 2013-07-05 16:32:30 UTC
Pull requested submitted @ https://github.com/fgnass/domino/pull/36
Comment 3 ssastry 2013-07-05 23:15:57 UTC
If this pull request is not merged soon, we can install the bugfix version @ https://github.com/subbuss/domino till it does.
Comment 4 James Forrester 2013-07-08 21:15:33 UTC
I see this has been merged in master - do we need to do a new deploy for this?
Comment 5 ssastry 2013-07-08 21:19:40 UTC
We need a newer version of domino to be released.  cscott (who I reassigned this bug to) will take care of that.  And after that, we will have to update package.json and update production (I assume new modules will be pulled as part of that deploy).  So, a couple more steps before this is in production.
Comment 6 C. Scott Ananian 2013-07-10 16:22:30 UTC
This is landed locally.  It just needs to be deployed to production now.

Are there any other additive formatting elements?  Parsoid should handle them all correctly now, but the PHP parser still has problems with nested <em> and <b> (see bug 51081).
Comment 7 Ed Sanders 2013-07-10 16:31:40 UTC
Per our fix on VE all elements should be considered additive as they may contain style="font-size: 110%"
Comment 8 ssastry 2013-07-11 16:49:31 UTC
New domino is in production.  And parsoid handles nesting of all formatting elements (even though php parser may not -- which cscott has a fix for in core).  Closing.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links