Last modified: 2013-09-02 12:40:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52605, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50605 - Hidden feedback posts remain visible in Special:Log/articlefeedbackv5


Summary:	Hidden feedback posts remain visible in Special:Log/articlefeedbackv5

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	ArticleFeedbackv5 (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-02 20:10 UTC by orlodrim
Modified:	2013-09-02 12:40 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description orlodrim 2013-07-02 20:10:56 UTC

The full content of feedback posts is displayed on Special:Log/articlefeedbackv5 (except for a few very long posts).

However, hiding a post in ArticleFeedback does not hide anything in this log. So if log entries are not hidden separately, hidden comments remain publicly visible (example: https://fr.wikipedia.org/w/index.php?title=Sp%C3%A9cial%3AJournal&type=articlefeedbackv5&offset=20130702191400&limit=3&uselang=en)

I think that the summary of the action "submitted feedback post..." should be hidden from this log when the post itself is hidden.

Comment 1 Gerrit Notification Bot 2013-07-11 15:39:49 UTC

Change 73182 had a related patch set uploaded by Matthias Mullie:
Don't add feedback comment to logs

https://gerrit.wikimedia.org/r/73182

Comment 2 Matthias Mullie 2013-07-11 15:43:34 UTC

https://gerrit.wikimedia.org/r/73182 will remove the feedback comment altogether, it will not even be saved (similar to how no content is saved to the log upon creating/editing a page)

Comment 3 orlodrim 2013-07-13 17:26:57 UTC

Thanks. That will give a bit more work to my bot to extract these comments, but that's life.

Comment 4 Gerrit Notification Bot 2013-08-14 17:39:07 UTC

Change 73182 merged by jenkins-bot:
Don't add feedback comment to logs

https://gerrit.wikimedia.org/r/73182

Comment 5 Andre Klapper 2013-09-02 12:40:53 UTC

(In reply to comment #4)
> Change 73182 merged by jenkins-bot:
> Don't add feedback comment to logs
> 
> https://gerrit.wikimedia.org/r/73182

Assuming this is FIXED.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links