Last modified: 2014-02-18 18:23:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52609, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50609 - VisualEditor: Cancelling out of adding a reference adds an empty reference
VisualEditor: Cancelling out of adding a reference adds an empty reference
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-02 21:16 UTC by Keegan Peterzell
Modified: 2014-02-18 18:23 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Keegan Peterzell 2013-07-02 21:16:48 UTC
From David Gerard on the en.wp feedback page: if you go to add a reference and then choose not to continue and exit out of the template and save the page instead of going back, VisualEditor creates an empty closed reference tab </re>.  See here:
https://en.wikipedia.org/w/index.php?title=User:David_Gerard&diff=562600190&oldid=545746964
Comment 1 David Gerard 2013-07-02 21:26:51 UTC
Note that this doesn't happen until you hit "Create reference" inside the first dialogue box, so you have arguably told it to create a reference ... but this will confuse people, because modal dialogue boxes in applications usually cancel out your actions if you just keep hitting the X. Arguably, it shouldn't create a reference if it's got nothing to put into the reference.
Comment 2 James Forrester 2013-07-03 01:20:16 UTC
(In reply to comment #1)
> Note that this doesn't happen until you hit "Create reference" inside the
> first dialogue box, so you have arguably told it to create a reference ...
> but this will confuse people, because modal dialogue boxes in applications
> usually cancel out your actions if you just keep hitting the X.

Agreed. We'll get this fixed.

> Arguably, it shouldn't create a reference if it's got nothing to put into
> the reference.

Are you telling users they're not allowed to do what they want?! ;-) I think that the number of users irritated by just silently munching references created as blank ("so I can come back to it later!") would be non-zero.
Comment 3 Krinkle 2013-07-03 01:24:07 UTC
This is because we currently have the logic for a creating refernece (and potentially re-using an existing reference) and actually interacting with the content of a reference in a separate dialog. As soon as you go into the editor it inserts an empty reference and lets you edit that.

This sounds like another reason to keep those two things in the same dialog (instead of making it look like one, actually have it be one). A dialog is perfectly capable of having multiple "pages" or "states". This would save a small amount of duplication and gain a fix for this bug and the bug of the animation between the two dialogs.
Comment 4 James Forrester 2014-02-18 18:23:00 UTC
This was fixed in (I think) August; sorry for not noting it until now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links