Last modified: 2013-07-03 23:30:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52612, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50612 - VisualEditor: Split mw.ViewPageTarget init from integration handling
VisualEditor: Split mw.ViewPageTarget init from integration handling
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-07-04
Assigned To: Krinkle
:
Depends on:
Blocks: 50542 50608 50692
  Show dependency treegraph
 
Reported: 2013-07-02 21:30 UTC by Krinkle
Modified: 2013-07-03 23:30 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-07-02 21:30:35 UTC
This doesn't mean that all of the integration needs to be independent (save dialog etc.) just the initialisation.

It used to be that the integration was only initialisation (instantiate the editor with the html document to edit, basically only up to a dozen lines of code) but it has become much more than that.

We need to separate integration and initialisation (initialisation will be part of the platform specific integration, but code-wise it should be the tip of the pyramid, not the bottom), so that our MediaWiki initialisation should be completely isolated so we can load it from the <head> and it will do only 2 things:

1) Browser compatibility test (bug 50608)
   - May depend on jQuery and a few plugins
   - May not depend on any VE classes since those may break in our subset
     of supported browsers (compared to MediaWiki/jQuery)

   (if passed)
2) Perform our changes to the interface to avoid flash of "pre-init" state
   - Edit tab (bug 50542)
   - Edit section links (bug 50540)
   - Handle setup/teardown of VE from either clicking an "Edit" link
     or by url query.
Comment 1 Gerrit Notification Bot 2013-07-03 22:16:21 UTC
Change 71929 had a related patch set uploaded by Krinkle:
Split off setup from the rest of mw.ViewPageTarget

https://gerrit.wikimedia.org/r/71929
Comment 2 Gerrit Notification Bot 2013-07-03 23:27:00 UTC
Change 71929 merged by jenkins-bot:
Split off setup from the rest of mw.ViewPageTarget

https://gerrit.wikimedia.org/r/71929
Comment 3 James Forrester 2013-07-03 23:30:23 UTC
This is now fixed (and deployed).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links